Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ima-hima
Copy link
Collaborator

I had some trouble making the .x1p file from the Dockerfile with the given instructions, so I made them way more detailed for the next guy like me who shows up and hasn't used Docker in a while.

Note that I left out `id -u` from all the docker commands. On the Mac that was causing problems, because it gives a different value than `id -u` does on Linux, and it didn't seem necessary, anyway. I did not test these commands on Linux or Windows, although since it's in a Docker container it should be platform-agnostic.

@jphannifan
Copy link
Contributor

I tested it on Windows a while back and as long as you install and run WSL before cloning the repo and building the docker image, it will work.

So I think we could include this somewhere as a note to Windows users:

wsl --install
wsl -d Ubuntu

@jphannifan
Copy link
Contributor

@ima-hima Thanks for writing out the setup instructions by the way! This will help a lot of people that may have had trouble building the docker image.

@scooterthedev
Copy link
Contributor

Note that I left out `id -u` from all the docker commands. On the Mac that was causing problems, because it gives a different value than `id -u` does on Linux, and it didn't seem necessary, anyway.

Funny thing is that Docker isn't really that platform-agnostic (at least from my experience). The command docker exec on WSL does not have the option of -v, and unless we run the other commands provided from Joshua (docker run), none of the commands will work, and it will refuse to build. It may be cleaner, and simpler to have the README formatted like this, but for Linux and WSL only, and have a dedicated page we can redirect Mac users too (maybe within the wiki), because at this moment, none of those commands will work for Linux or WSL (not sure about mac, as I am highly anti-apple lol). @jphannifan are you able to review these new commands from @ima-hima to make sure they work on a Mac?

@ima-hima
Copy link
Collaborator Author

ima-hima commented May 27, 2024

Note that I left out `id -u` from all the docker commands. On the Mac that was causing problems, because it gives a different value than `id -u` does on Linux, and it didn't seem necessary, anyway.

Funny thing is that Docker isn't really that platform-agnostic (at least from my experience). The command docker exec on WSL does not have the option of -v, and unless we run the other commands provided from Joshua (docker run), none of the commands will work, and it will refuse to build. It may be cleaner, and simpler to have the README formatted like this, but for Linux and WSL only, and have a dedicated page we can redirect Mac users too (maybe within the wiki), because at this moment, none of those commands will work for Linux or WSL (not sure about mac, as I am highly anti-apple lol). @jphannifan are you able to review these new commands from @ima-hima to make sure they work on a Mac?

Gah. That's so annoying. To be clear about what was happening, id -u on the Mac returns 501, at least if the user is the first registered user on the computer. That id increments for each new user added. When I attempted this on Ubuntu it returned 1000. However, my Ubuntu runs in a VM, so Docker doesn't actually work, as it needs KVM, which isn't available to me. Hard-coding 1000 did work on the Mac, but so did just not specifying a user in the docker command.

Since I'm complaining, also of note is that gcc-multilib doesn't seem to be available for ARM, so this won't compile at all on modern Apple hardware, and probably (due to the KVM issue above I wasn't able to actually test it) not on ARM Ubuntu, either.

@ima-hima
Copy link
Collaborator Author

@ima-hima Thanks for writing out the setup instructions by the way! This will help a lot of people that may have had trouble building the docker image.

You are so welcome!

@jphannifan
Copy link
Contributor

Since I'm complaining, also of note is that gcc-multilib doesn't seem to be available for ARM, so this won't compile at all on modern Apple hardware, and probably (due to the KVM issue above I wasn't able to actually test it) not on ARM Ubuntu, either.

You should be able to use Rosetta to run x86_64 binaries on any modern Apple device. I see it was recently added to Docker and is no longer considered an experimental feature: https://www.docker.com/blog/docker-desktop-4-25/

I installed Docker Desktop a few months ago just to enable this setting, but I use Docker's CLI for everything else. The only other setup that may be required is installing Rosetta
softwareupdate --install-rosetta

@jphannifan jphannifan self-requested a review June 6, 2024 19:14
jwise and others added 8 commits June 11, 2024 02:43
* add python packages pycryptodome, engineio, socketio for Polar; strip shared objects

* add pyftdi to the build
* x1plusd: there actually do not need to be any default settings in x1plus.services.x1plusd.settings, because clients are responsible for choosing their own defaults

* ota: default to enabled

* kexec_ui: correctly interpolate strings in BootOptionsPage cleanup mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants