-
Notifications
You must be signed in to change notification settings - Fork 59
Changes to Readme. #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes to Readme. #280
Conversation
|
I tested it on Windows a while back and as long as you install and run WSL before cloning the repo and building the docker image, it will work. So I think we could include this somewhere as a note to Windows users: |
|
@ima-hima Thanks for writing out the setup instructions by the way! This will help a lot of people that may have had trouble building the docker image. |
Funny thing is that Docker isn't really that platform-agnostic (at least from my experience). The command docker exec on WSL does not have the option of -v, and unless we run the other commands provided from Joshua (docker run), none of the commands will work, and it will refuse to build. It may be cleaner, and simpler to have the README formatted like this, but for Linux and WSL only, and have a dedicated page we can redirect Mac users too (maybe within the wiki), because at this moment, none of those commands will work for Linux or WSL (not sure about mac, as I am highly anti-apple lol). @jphannifan are you able to review these new commands from @ima-hima to make sure they work on a Mac? |
Gah. That's so annoying. To be clear about what was happening, Since I'm complaining, also of note is that |
You are so welcome! |
You should be able to use Rosetta to run x86_64 binaries on any modern Apple device. I see it was recently added to Docker and is no longer considered an experimental feature: https://www.docker.com/blog/docker-desktop-4-25/ I installed Docker Desktop a few months ago just to enable this setting, but I use Docker's CLI for everything else. The only other setup that may be required is installing Rosetta |
* add python packages pycryptodome, engineio, socketio for Polar; strip shared objects * add pyftdi to the build
* x1plusd: there actually do not need to be any default settings in x1plus.services.x1plusd.settings, because clients are responsible for choosing their own defaults * ota: default to enabled * kexec_ui: correctly interpolate strings in BootOptionsPage cleanup mechanism
I had some trouble making the .x1p file from the Dockerfile with the given instructions, so I made them way more detailed for the next guy like me who shows up and hasn't used Docker in a while.
Note that I left out
`id -u`from all the docker commands. On the Mac that was causing problems, because it gives a different value than`id -u`does on Linux, and it didn't seem necessary, anyway. I did not test these commands on Linux or Windows, although since it's in a Docker container it should be platform-agnostic.