Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: SmartEscrow fee voting changes #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: ripple/wamr-host-functions
Choose a base branch
from
Open

feat: SmartEscrow fee voting changes #5810

wants to merge 15 commits into from
+649 −53

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Sep 22, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari marked this pull request as ready for review September 22, 2025 22:23
@codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.21488% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.0%. Comparing base (286dc63) to head (af6beb1).

Files with missing lines Patch % Lines
src/xrpld/app/ledger/Ledger.cpp 82.8% 5 Missing ⚠️
src/xrpld/app/misc/FeeVoteImpl.cpp 97.4% 1 Missing ⚠️
src/xrpld/app/tx/detail/Change.cpp 92.3% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           ripple/wamr-host-functions   #5810    +/-   ##
===========================================================
  Coverage                        78.9%   79.0%            
===========================================================
  Files                             826     826            
  Lines                           71030   71145   +115     
  Branches                         8360    8366     +6     
===========================================================
+ Hits                            56070   56175   +105     
- Misses                          14960   14970    +10
Files with missing lines Coverage Δ
include/xrpl/protocol/Fees.h 100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
src/libxrpl/protocol/STValidation.cpp 81.8% <ø> (ø)
src/xrpld/app/misc/NetworkOPs.cpp 70.3% <100.0%> (+0.5%) ⬆️
src/xrpld/core/Config.h 84.6% <ø> (ø)
src/xrpld/core/detail/Config.cpp 75.2% <100.0%> (+0.3%) ⬆️
src/xrpld/app/misc/FeeVoteImpl.cpp 96.0% <97.4%> (+0.4%) ⬆️
src/xrpld/app/tx/detail/Change.cpp 71.1% <92.3%> (+1.1%) ⬆️
src/xrpld/app/ledger/Ledger.cpp 82.8% <82.8%> (-<0.1%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vvysokikh1 vvysokikh1 vvysokikh1 approved these changes

@oleks-rip oleks-rip Awaiting requested review from oleks-rip

@pwang200 pwang200 Awaiting requested review from pwang200

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvadari @vvysokikh1