Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Jul 17, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jul 17, 2021
@atomist atomist bot added auto-merge-method:merge Auto-merge with merge commit auto-merge:on-bpr-success Auto-merge on passed branch protection rule auto-branch-delete:on-close Delete branch when pull request gets closed labels Jul 17, 2021
bennettpeter and others added 26 commits July 17, 2025 17:47
… groups.

Themes can add a
<buttonlist name="groupsAlphabet">
to
<window name="watchrecordings">

When the user presses left (up) from the Groups list they will be presented with
the list of first letters allowing quick navigation to a group/show title.
Show the recordedtime in the slider info not only for recordings
that have been completed but also for recordings in progress.
1) Use pass-by-value and std::move for a function argument.

2) Its unknown whether or not the std::optional variable has a value
   when it is dereferenced.  Add a default value in case the variable
   has never been assigned.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone/unchecked-optional-access.html
https://clang.llvm.org/extra/clang-tidy/checks/modernize/pass-by-value.html
Fix warning that a range loop could cause a container to detach by
marking it as const.

https://github.com/KDE/clazy/blob/master/docs/checks/README-range-loop-detach.md
Fix the following APIS. User's language is used with class MythSortHelper

- Dvr/GetOldRecordedList: title and subtitle
- Dvr/GetUpcomingList: title
- Dvr/GetConflictList: title
- Video/GetVideoList: title, subtitle, directory name
- Dvr/GetRecordScheduleList: title
- Dvr/GetRecordedList: title, subtitle
In conjunction with service API changes, the following pages now
ignore articles in sorting:

Recordings: title and subtitle
Previously Recorded: title and subtitle
Upcoming: title
Recording Rules: title
Videos: title, directory name and subtitle

Refs #1150
The header file needs to declare symbols as Q_DECL_EXPORT when the
library is compiled, and Q_DECL_IMPORT when included by a caller of
the library.

This is based on a patch from Z. Liu <[email protected]>.

Fixes #1153.
Qt container operator[] functions (on non-const containers) will
always create a new entry in the container if it doesn't already
exist.  This makes sense when the container is on the left side of an
assignment (its being written), but is counter-intuitive when the
container is on the right side of an assignment (its being read).  Use
the value() function instead of operator[] as it will never create a
new entry in a container.
Converting these for loops to operate on a const container means that
the begin/end functions can never modify the container.  Converting
them to range-for loops simplifies the code a little bit.  Also mark a
couple of SocketHandler functions as "const" so they can be called
when working with a const object.
The read lock in this function is on TVRec::s_inputsLock, which is
designed to protect TVRec::s_inputs.  The container being modified is
m_usedEncoders, so this warning can be marked as a false positive.
  Add code to locate and correct missing Qt framworks "skipped" by
  macdeployqt when bundling the mythfrontend app.  This issue only
  occurs on homebrew based builds that use QtWebengine.

  For some reason, QtQuickWidgets.framework does not get
  copied into the app framework by macdeployqt. This update searches
  for any missing Qt frameworks, copies the missing frameworks into the
  app bundle, and corrects any libraries contained in the framework.
This was causing TestCopyFrames to abort after
passing all of the tests on macOS 15.
which the CMake build does and the check for vaCreateSurfaces()
effectively already did.
MythTV requires at least a C11 compiler for FFmpeg and
Visual Studio 2019 version 16.8 (released November 2020)
supports the restrict and inline keywords in /std=c11 mode.

restrict is only used by FFmpeg and one file in libmpeg2.
Visual Studio 2019 version 16.8 defines _MSC_VER to 1928
and is required for C11 support (restrict and inline).
ulmus-scott and others added 30 commits December 9, 2025 21:02
This is left over from FFmpeg; MythTV is GPLv2-only and
unconditionally enables GPL for FFmpeg.
Let FFmpeg's configure auto-detect SDL2 and build
mythffplay if it was found.
This also removes the random options.
This is only used by FFmpeg and is not passed through.
The resulting HAVE_* symbols are either never used or only used
in FFmpeg.
FFmpeg uses the restrict keyword without substitution
so we don't need to replace it.
FFmpeg removed support from their configure:
FFmpeg/FFmpeg@09c9832
MythTV requires pthreads, so remove references to
other thread options (that MythTV wouldn't use anyways).

sem_timedwait() is only used in FFmpeg.  frame_thread_encoder
is an FFmpeg feature.
SA_RESTART is used without the HAVE_ guard
and the others are only used in FFmpeg.
MythTV only uses lrintf(), not llrint(), nor lrint().  Regardless,
the checks for lrint and round did not effect the output.

MythTV no longer uses sync_file_range().
They are checked later and these checks do not effect the output.
ftime() is only used in libdvdnav and libdvdread on Windows if
gettimeofday() is not available and does not use HAVE_FTIME.
Fix bug where if you update the Orig Airdate and then try to update it
again it shows date as NaN NaN NaN, unless you refresh the page.
Use fully accurate seeks for the arrow LEFT and arrow RIGHT actions
in the cutlist editor when the seek amount is less than 6 seconds.
Given the possible values of the seek amount, this means that the one second
and five second seek amount actions are now frame-level accurate.

Refs #1195
Ignore the FL_TYPEMASK bits in m_programFlags when converting the bitmask
to a string in the cutlist editor. This fixes the following error message:
programinfo.cpp:1475:propsValueToString Unknown name for program flag 0x0x00100000
This removes more code from configure, but doesn't really change the time it takes to run.

It also replaces and removes a few defines.
Thanks to @mosource21 for the bug report and @rcrdnalor for the fix!

Note that themes that have a copy of the programdetails block in their
schedule-ui.xml may override this and still have the truncated
descriptions bug.  If so they will need the same fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ pull auto-branch-delete:on-close Delete branch when pull request gets closed auto-merge:on-bpr-success Auto-merge on passed branch protection rule auto-merge-method:merge Auto-merge with merge commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants