forked from MythTV/mythtv
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from MythTV:master #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
4,084
commits into
majacQ:master
Choose a base branch
from
MythTV:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on the currently active buttonlist.
… groups. Themes can add a <buttonlist name="groupsAlphabet"> to <window name="watchrecordings"> When the user presses left (up) from the Groups list they will be presented with the list of first letters allowing quick navigation to a group/show title.
Show the recordedtime in the slider info not only for recordings that have been completed but also for recordings in progress.
1) Use pass-by-value and std::move for a function argument. 2) Its unknown whether or not the std::optional variable has a value when it is dereferenced. Add a default value in case the variable has never been assigned. https://clang.llvm.org/extra/clang-tidy/checks/bugprone/unchecked-optional-access.html https://clang.llvm.org/extra/clang-tidy/checks/modernize/pass-by-value.html
Fix warning that a range loop could cause a container to detach by marking it as const. https://github.com/KDE/clazy/blob/master/docs/checks/README-range-loop-detach.md
Fix the following APIS. User's language is used with class MythSortHelper - Dvr/GetOldRecordedList: title and subtitle - Dvr/GetUpcomingList: title - Dvr/GetConflictList: title - Video/GetVideoList: title, subtitle, directory name - Dvr/GetRecordScheduleList: title - Dvr/GetRecordedList: title, subtitle
In conjunction with service API changes, the following pages now ignore articles in sorting: Recordings: title and subtitle Previously Recorded: title and subtitle Upcoming: title Recording Rules: title Videos: title, directory name and subtitle Refs #1150
The header file needs to declare symbols as Q_DECL_EXPORT when the library is compiled, and Q_DECL_IMPORT when included by a caller of the library. This is based on a patch from Z. Liu <[email protected]>. Fixes #1153.
Qt container operator[] functions (on non-const containers) will always create a new entry in the container if it doesn't already exist. This makes sense when the container is on the left side of an assignment (its being written), but is counter-intuitive when the container is on the right side of an assignment (its being read). Use the value() function instead of operator[] as it will never create a new entry in a container.
Converting these for loops to operate on a const container means that the begin/end functions can never modify the container. Converting them to range-for loops simplifies the code a little bit. Also mark a couple of SocketHandler functions as "const" so they can be called when working with a const object.
The read lock in this function is on TVRec::s_inputsLock, which is designed to protect TVRec::s_inputs. The container being modified is m_usedEncoders, so this warning can be marked as a false positive.
Add code to locate and correct missing Qt framworks "skipped" by macdeployqt when bundling the mythfrontend app. This issue only occurs on homebrew based builds that use QtWebengine. For some reason, QtQuickWidgets.framework does not get copied into the app framework by macdeployqt. This update searches for any missing Qt frameworks, copies the missing frameworks into the app bundle, and corrects any libraries contained in the framework.
This was causing TestCopyFrames to abort after passing all of the tests on macOS 15.
which the CMake build does and the check for vaCreateSurfaces() effectively already did.
MythTV requires at least a C11 compiler for FFmpeg and Visual Studio 2019 version 16.8 (released November 2020) supports the restrict and inline keywords in /std=c11 mode. restrict is only used by FFmpeg and one file in libmpeg2.
Visual Studio 2019 version 16.8 defines _MSC_VER to 1928 and is required for C11 support (restrict and inline).
This is left over from FFmpeg; MythTV is GPLv2-only and unconditionally enables GPL for FFmpeg.
Let FFmpeg's configure auto-detect SDL2 and build mythffplay if it was found.
This also removes the random options.
This is only used by FFmpeg and is not passed through.
The resulting HAVE_* symbols are either never used or only used in FFmpeg.
Some are used only in FFmpeg.
FFmpeg uses the restrict keyword without substitution so we don't need to replace it.
FFmpeg removed support from their configure: FFmpeg/FFmpeg@09c9832
MythTV requires pthreads, so remove references to other thread options (that MythTV wouldn't use anyways). sem_timedwait() is only used in FFmpeg. frame_thread_encoder is an FFmpeg feature.
SA_RESTART is used without the HAVE_ guard and the others are only used in FFmpeg.
MythTV only uses lrintf(), not llrint(), nor lrint(). Regardless, the checks for lrint and round did not effect the output. MythTV no longer uses sync_file_range().
They are checked later and these checks do not effect the output.
ftime() is only used in libdvdnav and libdvdread on Windows if gettimeofday() is not available and does not use HAVE_FTIME.
Fix bug where if you update the Orig Airdate and then try to update it again it shows date as NaN NaN NaN, unless you refresh the page.
Use fully accurate seeks for the arrow LEFT and arrow RIGHT actions in the cutlist editor when the seek amount is less than 6 seconds. Given the possible values of the seek amount, this means that the one second and five second seek amount actions are now frame-level accurate. Refs #1195
Ignore the FL_TYPEMASK bits in m_programFlags when converting the bitmask to a string in the cutlist editor. This fixes the following error message: programinfo.cpp:1475:propsValueToString Unknown name for program flag 0x0x00100000
This removes more code from configure, but doesn't really change the time it takes to run. It also replaces and removes a few defines.
Thanks to @mosource21 for the bug report and @rcrdnalor for the fix! Note that themes that have a copy of the programdetails block in their schedule-ui.xml may override this and still have the truncated descriptions bug. If so they will need the same fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⤵️ pull
auto-branch-delete:on-close
Delete branch when pull request gets closed
auto-merge:on-bpr-success
Auto-merge on passed branch protection rule
auto-merge-method:merge
Auto-merge with merge commit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )