majacQ · pull · Jul 17, 2025 · Jul 13, 2025 · Jul 18, 2025 · Jul 20, 2025
diff --git a/.clang-tidy b/.clang-tidy
@@ -35,47 +35,83 @@
 #HeaderFilterRegex: '^((\./)?([[:alnum:]]+/)?[[:alnum:]]+\.h|\.\./[[:alnum:]]+/[[:alnum:]]+\.h|\.\./\.\./libmyth[[:alnum:]]+/[[:alnum:]]+\.h|\.\./\.\./external/libmythsoundtouch/[[:alnum:]]+\.h)$'
 #,
 HeaderFilterRegex: '^((\./)?([[:alnum:]]+/)?[[:alnum:]]+\.h|\.\./[[:alnum:]]+/[[:alnum:]]+\.h|\.\./\.\./libmyth[[:alnum:]]+/[[:alnum:]]+\.h)$'
+UseColor: true
 
 Checks: '-*,
 
     bugprone-*,
 
-       -bugprone-misplaced-widening-cast,
-
-        # Renamed/replaced by cppcoreguidelines-narrowing-conversions. ,
+        # Skip tests that are redirects to other tests. ,
        -bugprone-narrowing-conversions,
 
-        # Doesn''t distinguish between identifiers in the code and
-        # those supplied on the command line with "-X_FOO=BAR". The
-        # only remaining positives are those passed on the command
-        # line. New in clang11. ,
-       -bugprone-reserved-identifier,
+        # As of 2022-12-19, there are 1014 unique warnings. ,
+       -bugprone-easily-swappable-parameters,
+
+        # As of 2023-05-22, there are 97 unique warnings. ,
+       -bugprone-implicit-widening-of-multiplication-result,
+
+        # As of 2023-09-19, there are 140 unique warnings. ,
+       -bugprone-switch-missing-default-case,
 
     cert-*,
 
-	# Aliases for bugprone-reserved-identifier,
+        # Skip tests that are redirects to other tests. ,
+       -cert-con36-c,
+       -cert-con54-cpp,
+       -cert-ctr56-cpp,
+       -cert-dcl03-c,
+       -cert-dcl16-c,
        -cert-dcl37-c,
        -cert-dcl51-cpp,
+       -cert-dcl54-cpp,
+       -cert-dcl59-cpp,
+       -cert-err09-cpp,
+       -cert-err61-cpp,
+       -cert-exp42-c,
+       -cert-fio38-c,
+       -cert-flp37-c,
+       -cert-int09-c,
+       -cert-msc24-c,
+       -cert-msc30-c
+       -cert-msc32-c,
+       -cert-msc33-c,
+       -cert-msc54-cpp,
+       -cert-oop11-cpp,
+       -cert-oop54-cpp,
+       -cert-pos44-c,
+       -cert-pos47-c,
+       -cert-sig30-c,
+       -cert-str34-c,
 
-        # Dont declare c-style varardic functions. ,
+        # Dont declare c-style varardic functions. As of 2022-12-19,
+        # there are 2 warnings: lirc_client.cpp and vbi.cpp. ,
        -cert-dcl50-cpp,
 
-        # Using function invokes a command interpreter. Should fix. ,
+        # Using function invokes a command interpreter. Should fix.
+        # As of 2022-12-19, there are 9 warnings. ,
        -cert-env33-c,
 
+        # Calls to standard library functions where the return value
+        # isnt checked. These should all be fixed. As of 2023-05-22,
+        # there are 340 warnings. ,
+       -cert-err33-c,
+
         # string-to-number conversion functions that do not verify the
-        # validity of the conversion. Needs work. ,
+        # validity of the conversion.  As of 2023-05-22, there are 43
+        # warnings. ,
        -cert-err34-c,
 
         # Lots of complaints about constructors of static objects
-        # possibly throwing exceptions that cant be caught.  These
-        # all appear to be within Qt code that cant be fixed by us. ,
+        # possibly throwing exceptions that cant be caught. As of
+        # 2023-05-22, there are 508 warnings. ,
        -cert-err58-cpp,
 
-        # Similar to bugprone-signed-char-misuse but not quite the same. ,
-       -cert-str34-c,
-
     clang-analyzer-*,
+        # This complains about all instances where an enum is used to
+        # define a set of bit flags, and then one or more of those
+        # flags are or-ed together. ,
+       -clang-analyzer-optin.core.EnumCastOutOfRange,
+
         # The "safe" versions functions were optional in the standard
         # and were never implemented by GCC or Clang.  There has been
         # a move to have these functions removed from the standard as
@@ -84,113 +120,185 @@ Checks: '-*,
        -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
        -clang-analyzer-security.insecureAPI.strcpy,
 
-    # Explicitly list the tests that arent aliases. ,
-   -cppcoreguidelines-*,
+        # Disable these warnings until they can be analyzed. ,
+       -clang-analyzer-optin.cplusplus.VirtualCall,
+
+        # Disable new WebKit warnings.  They should only apply to code
+        # specifically related to WebKit (which MythTV only accesses
+        # via QtWebEngine), but they are currently applied
+        # everywhere. ,
+       -clang-analyzer-webkit.*,
+
+    cppcoreguidelines-*,
+
+        # Skip tests that are redirects to other tests. ,
+       -cppcoreguidelines-avoid-c-arrays,
+       -cppcoreguidelines-avoid-magic-numbers,
+       -cppcoreguidelines-c-copy-assignment-signature,
+       -cppcoreguidelines-explicit-virtual-functions,
+       -cppcoreguidelines-macro-to-enum,
+       -cppcoreguidelines-noexcept-destructor,
+       -cppcoreguidelines-noexcept-move-operations,
+       -cppcoreguidelines-noexcept-swap,
+       -cppcoreguidelines-non-private-member-variables-in-classes,
+       -cppcoreguidelines-use-default-member-init,
+
+        # Skip tests that recommend usage of the Microsoft Guidelines
+        # Support Library.  https://github.com/microsoft/GSL ,
+       -cppcoreguidelines-owning-memory,
+       -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+       -cppcoreguidelines-pro-bounds-constant-array-index,
+
+        # Skip tests that recommend usage of the boost:: framework to
+        # access unions. https://www.boost.org/ ,
+       -cppcoreguidelines-pro-type-union-access,
 
-        # Good. ,
-        cppcoreguidelines-init-variables,
-        cppcoreguidelines-interfaces-global-init,
-        cppcoreguidelines-pro-type-member-init,
-        cppcoreguidelines-pro-type-static-cast-downcast,
+        # As of 2024-08-01, there are 110 unique warnings. ,
+       -cppcoreguidelines-avoid-const-or-ref-data-members,
 
-        # Needs work. ,
-       -cppcoreguidelines-avoid-goto,
+        # As of 2024-08-01, there are 12256 unique warnings. ,
+       -cppcoreguidelines-avoid-do-while,
 
-        # About 20,000 of warnings. ,
+        # As of 2023-05-22, there are 1257 unique warnings. ,
        -cppcoreguidelines-avoid-non-const-global-variables,
 
-        # Tons of warnings.  Most complaining that #define should
-        # become a constexpr. ,
+        # As of 2024-08-01, there are 2 warnings. ,
        -cppcoreguidelines-macro-usage,
 
-        # Bunch of warnings.... ,
+        # As of 2023-05-22, there are 374 unique warnings. ,
        -cppcoreguidelines-narrowing-conversions,
-       -cppcoreguidelines-no-malloc,
 
-        # No gsl. ,
-       -cppcoreguidelines-owning-memory,
-
-        # No gsl. Warning on every log message.
-        # "do not implicitly decay an array into a pointer; consider
-        #  using gsl::array_view or an explicit cast instead" ,
-       -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
-
-        # No gsl. Recommends gsl::at be used in 1611 places. ,
-       -cppcoreguidelines-pro-bounds-constant-array-index,
+        # As of 2024-08-02, there are 210 unique warnings. ,
+       -cppcoreguidelines-no-malloc,
 
-        # Bunch of warnings.... ,
+        # As of 2024-08-02, there are 4624 unique warnings. ,
        -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+
+        # As of 2024-08-02, there are 22 unique warnings. ,
        -cppcoreguidelines-pro-type-const-cast,
-        # Bunch of warnings.... ,
+
+        # As of 2023-05-22, there are 744 unique warnings. ,
        -cppcoreguidelines-pro-type-cstyle-cast,
 
-        # Haven''t checked recently. ,
+        # As of 2024-08-02, there are 498 unique warnings. ,
        -cppcoreguidelines-pro-type-reinterpret-cast,
 
-        # Recommends using boost:: to access unions. ,
-       -cppcoreguidelines-pro-type-union-access,
-
         # Warns on every (*)printf, sscanf,open, ioctl, etc. ,
        -cppcoreguidelines-pro-type-vararg,
 
+        # As of 2024-08-02, there are 140 unique warnings. ,
        -cppcoreguidelines-slicing,
+
+        # As of 2024-08-02, there are 1547 unique warnings. ,
        -cppcoreguidelines-special-member-functions,
 
+        # As of 2025-06-28, there are 959 unique warnings. ,
+       -cppcoreguidelines-use-enum-class,
+
+        # As of 2024-08-01, there are 207 unique warnings. ,
+       -cppcoreguidelines-virtual-class-destructor,
+
    -google-explicit-constructor,
    -google-runtime-int,
 
     misc-*,
 
-        # Cases exist. Need to add getters/setters to classes. ,
+        # As of 2024-08-02, there are 15970 unique warnings. ,
+       -misc-const-correctness,
+
+        # As of 2023-09-19, there are 115517 unique warnings. ,
+       -misc-include-cleaner,
+
+        # Complains about every public or protected variable in a class. ,
        -misc-non-private-member-variables-in-classes,
 
-        # The Q_DECLARE_METATYPE macro triggers a warning from
-        # this checker. There are also a handful of places where
-        # MythTV uses recursion on purpose. These should be checked to
-        # ensure there are no problems. ,
+        # As of 2028-08-02, there are 420 unique warnings. 195 are
+        # related to the Q_DECLARE_METATYPE macro and the other 225
+        # are in MythTV. ,
        -misc-no-recursion,
 
+        # New in clang16. As of 2023-05-03, there are 1445 unique
+        # warnings. ,
+       -misc-use-anonymous-namespace,
+
+        # Temporarily disable this. ,
+       -misc-use-internal-linkage,
+
     modernize-*,
 
         # Noisy!!!  foo(void) => foo()  ,
        -modernize-redundant-void-arg,
 
+        # As of 2024-08-08, all remaining warnings remaining come from
+        # calls to QFETCH Q_GLOBAL_STATIC_WITH_ARGS and cant be fixed
+        # by us. ,
+       -modernize-type-traits,
+
         # Why would anyone want this? ,
        -modernize-use-trailing-return-type,
 
         # Disable newer C++14/17 tests for now. ,
        -modernize-use-nodiscard,
 
+        # Renamed from cppcoreguidelines-macro-to-enum in clang15. As
+        # of 2023-05-22, there are 41 unique warnings. ,
+       -modernize-macro-to-enum,
+
     performance-*,
 
-        # The Q_DECLARE_METATYPE macro triggers a warning from this
-        # new clang12 checker. ,
-        -performance-no-int-to-ptr,
+        # As of 2023-09-19, there are 443 unique warnings. ,
+       -performance-avoid-endl,
+
+        # As of 2025-03-13, new filtering reduces this count to 7
+        # unique warnings. ,
+       -performance-no-int-to-ptr,
 
     readability-*,
 
-        # Need to decide on an appropriate value. ,
+        # As of 2023-09-19, there are 315 unique warnings. ,
+       -readability-avoid-unconditional-preprocessor-if,
+
+        # Need to decide on an appropriate value.  As of 2024-08-02
+        # there are 1753 unique warnings at the default complexity
+        # value. ,
        -readability-function-cognitive-complexity,
 
-        # Not investigated yet. ,
+        # Need to decide on an appropriate value.  As of 2024-08-02
+        # there are only 2 unique warnings at the default size limit
+        # of 800 statements. ,
        -readability-function-size,
 
-        # Wants to rewrite lots of implicit nullptr tests. ,
+        # Whats wrong with single character variable names? As of
+        # 2022-12-19, there are 9889 unique warnings. ,
+       -readability-identifier-length,
+
+        # Wants to rewrite lots of implicit nullptr tests. As of
+        # 2022-12-19, there are 426 unique warnings. ,
        -readability-implicit-bool-conversion,
 
-        # Lots of noise. Needs work. ,
+        # As of 2023-05-22, there are 14798 unique warnings. ,
        -readability-magic-numbers,
 
         # Doesn''t understand Qt signals/slots. ,
        -readability-redundant-access-specifiers,
 
+        # Wants to rewrite every use of 127/255 as a reference to
+        # std::numeric_limits. ,
+       -readability-use-numeric-limits,
+
 '
 
 CheckOptions:
+  - { key: bugprone-narrowing-conversions.PedanticMode, value: 0 }
   - { key: bugprone-suspicious-string-compare.WarnOnLogicalNotComparison, value: 1 }
+  - { key: bugprone-pointer-arithmetic-on-polymorphic-object.IgnoreInheritedVirtualFunctions, value: 1 }
+  - { key: bugprone-unused-return-value.AllowCastToVoid, value: 1 }
 
+  - { key: cppcoreguidelines-avoid-do-while.IgnoreMacros, value: 1 }
+  - { key: cppcoreguidelines-avoid-non-const-global-variables.AllowInternalLinkage, value: 1 }
   - { key: cppcoreguidelines-pro-type-member-init.IgnoreArrays, value: 1 }
-  - { key: cppcoreguidelines-narrowing-conversions.PedanticMode, value: 0 } # test 1 at some point
+
+  - { key: misc-header-include-cycle.IgnoredFilesList, value: 'qglobal.h;mem.h;common.h' }
 
   - { key: modernize-make-shared.IgnoreMacros,             value: 0 }
   - { key: modernize-make-unique.IgnoreMacros,             value: 0 }
@@ -203,10 +311,11 @@ CheckOptions:
   - { key: performance-inefficient-vector-operation.VectorLikeClasses,
     value: '::std::vector,QList,QByteArrayList,QItemSelection,QQueue,QStringList' }
 
-  - { key: readability-braces-around-statements.ShortStatementLines,       value: 3 }
+  - { key: readability-braces-around-statements.ShortStatementLines,       value: 4 }
   - { key: readability-implicit-bool-conversion.AllowPointerConditions,    value: 1 }
   - { key: readability-implicit-bool-conversion.AllowIntegerConditions,    value: 1 }
   - { key: readability-inconsistent-declaration-parameter-name.strict,     value: 1 }
+  - { key: readability-redundant-member-init.IgnoreBaseInCopyConstructors, value: 1 }
   - { key: readability-redundant-declaration.IgnoreMacros,                 value: 0 }
   - { key: readability-simplify-boolean-expr.chainedconditionalreturn,     value: 1 }
   - { key: readability-simplify-boolean-expr.chainedconditionalassignment, value: 1 }