Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validation patch #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Validation patch #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1cca7c
fix dylist in hbv 1.1p
leoglonz Oct 12, 2025
2beb884
update precommit and workflows
leoglonz Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
uses: actions/[email protected]

- name: Install uv + Python
uses: astral-sh/setup-uv@v6.7.0
uses: astral-sh/setup-uv@v7.0.0
with:
python-version: ${{ matrix.python-version }}
enable-cache: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
steps:
- name: Checkout code
uses: actions/[email protected]

- name: Install uv + Python
uses: astral-sh/setup-uv@v6.7.0
uses: astral-sh/setup-uv@v7.0.0
with:
python-version: ${{ matrix.python-version }}
enable-cache: true
Expand Down
22 changes: 16 additions & 6 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,27 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
rev: v5.0.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-yaml
exclude: "mkdocs.*\\.yml$" # Exclude mkdocs YAML files
exclude: "mkdocs.*\\.yml$"
- id: debug-statements
- id: check-toml

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.5 # Use whatever version you're currently using
rev: v0.13.2
hooks:
- id: ruff
args: [--fix]
exclude: "hooks/.*\\.py$" # Exclude the hooks directory from ruff
- id: ruff-check
types_or: [python, pyi, jupyter]
args: [--fix, --config, pyproject.toml]
- id: ruff-format
types_or: [python, pyi, jupyter]
args: [--config, pyproject.toml]

- repo: https://github.com/kynan/nbstripout
rev: 0.8.1
hooks:
- id: nbstripout
types: [jupyter]
language_version: python3
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies = [
"pre-commit>=4.3.0",
"sourcedefender>=15.0.14",
"torch>=2.8.0",
"uv>=0.8.22",
"uv>=0.9.2",
]
classifiers = [
"Programming Language :: Python :: 3",
Expand All @@ -36,7 +36,7 @@ classifiers = [
dev = [
"ipywidgets>=8.1.7",
"pytest>=8.4.2",
"ruff>=0.13.2",
"ruff>=0.14.0",
]

[project.urls]
Expand Down
2 changes: 1 addition & 1 deletion src/hydrodl2/models/hbv/hbv_1_1p.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def forward(
with torch.no_grad():
phy_param_warmup_dict = self.descale_phy_parameters(
phy_params[:warm_up, :, :],
dy_list=[],
dy_list=self.dynamic_params,
)
# Save current model settings.
initialize = self.initialize
Expand Down