Mininet patches from Big Switch #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building the package
…ttern in the command output
an unprivileged Python process
like SIGINT (this wasn't a problem before the previous change which ran each subprocess with sudo; for some reason SIGINT behaves itself when the shell is spawned directly); set the shell prompt to ASCII 127 to make it easy to find the end of each command; echo a serial number to ensure the output of multiple commands is synchronized with the caller
spawned in a pseudo-tty
Switch class so tests don't have to guess the dpid
Member
Author
|
Closing this request to rebase in the right direction. |
bocon13
pushed a commit
that referenced
this pull request
Jul 23, 2013
Simplified and refactored examples/dynamicnet.py
lantz
pushed a commit
that referenced
this pull request
Mar 2, 2015
Move cmdloop() wrapper into a new run() method
lantz
pushed a commit
that referenced
this pull request
Apr 27, 2017
update install.sh fixing ryu install
akoshibe
referenced
this pull request
in akoshibe/mininet
May 2, 2017
pull request #1 from leonardodavila/fix-ryu-install update install.sh fixing ryu install
vasu-dasari
pushed a commit
to vasu-dasari/mininet
that referenced
this pull request
Feb 2, 2018
Make LINC run with remote controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, here is the first batch of mininet patches from big switch; normally they would create the pull request, but to get things started and to facilitate some discussion and code review, I've created the pull request myself.
I haven't reviewed everything, but a couple of things I've seen so far look pretty reasonable, including using sudo so Mininet is only root for the root-like things it needs to do (and so it can be imported into average python code not running as root), and a fix for the annoying control-c-kills-your-xterms (and other subprocesses) bug (assuming that the fix is good and works.)
Although this is a mass of patches, we may want to cherry-pick specific commits.
I'm (hopefully) cc'ing Ed and Mike from big switch so they can join the discussion.
/cc @eswierk @mscohen02