Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: bump strip-json-comments from 3 to 5 #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
JoshuaKGoldberg wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: bump strip-json-comments from 3 to 5 #5484

JoshuaKGoldberg wants to merge 5 commits into from
+68 −10

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 2, 2025 •
edited
Loading

PR Checklist

Overview

Bumps the package from ^3.1.1 to ^5.0.3.

Similar to #5482, this increases the lockfile size for local development dependencies. This is because strip-json-comments@3 is still referenced by:

$ npm ls strip-json-comments@3
[email protected] /Users/josh/repos/mocha
├─┬ [email protected]
│ └─┬ @eslint/[email protected]
│   └── [email protected]
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

💖

This was referenced Oct 2, 2025
Closed
Open
Closed
Draft
@mark-wiemer
Copy link
Member

mark-wiemer commented Oct 3, 2025

require(...) is not a function is definitely a new failure to me... have fun :D

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 6, 2025
Open
5 tasks
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Nov 27, 2025 •
edited
Loading

This reproduces locally with npx mocha test/integration/config.spec.js:

Full failure from that test command 
 Exception during run: Error: Unable to read/parse /Users/josh/repos/mocha/test/integration/fixtures/config/mocharc.json: TypeError: require(...) is not a function
    at createUnparsableFileError (/Users/josh/repos/mocha/lib/errors.js:408:13)
    at exports.loadConfig (/Users/josh/repos/mocha/lib/cli/config.js:81:11)
    at Suite.<anonymous> (/Users/josh/repos/mocha/test/integration/config.spec.js:25:16)
    at Object.create (/Users/josh/repos/mocha/lib/interfaces/common.js:153:19)
    at context.describe.context.context (/Users/josh/repos/mocha/lib/interfaces/bdd.js:46:27)
    at Suite.<anonymous> (/Users/josh/repos/mocha/test/integration/config.spec.js:22:3)
    at Object.create (/Users/josh/repos/mocha/lib/interfaces/common.js:153:19)
    at context.describe.context.context (/Users/josh/repos/mocha/lib/interfaces/bdd.js:46:27)
    at Object.<anonymous> (/Users/josh/repos/mocha/test/integration/config.spec.js:10:1)
    at Module._compile (node:internal/modules/cjs/loader:1692:14)
    at Object..js (node:internal/modules/cjs/loader:1824:10)
    at Module.load (node:internal/modules/cjs/loader:1427:32)
    at Module._load (node:internal/modules/cjs/loader:1250:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
    at cjsLoader (node:internal/modules/esm/translators:316:5)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:208:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:365:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:665:26)
    at async formattedImport (/Users/josh/repos/mocha/lib/nodejs/esm-utils.js:10:14)
    at async Object.requireModule [as requireOrImport] (/Users/josh/repos/mocha/lib/nodejs/esm-utils.js:102:30)
    at async exports.loadFilesAsync (/Users/josh/repos/mocha/lib/nodejs/esm-utils.js:155:20)
    at async singleRun (/Users/josh/repos/mocha/lib/cli/run-helpers.js:174:3)
    at async exports.handler (/Users/josh/repos/mocha/lib/cli/run.js:372:5) {
  code: 'ERR_MOCHA_UNPARSABLE_FILE'
}
Wrapped err in loadConfig 
TypeError: require(...) is not a function
    at Object.json (/Users/josh/repos/mocha/lib/cli/config.js:55:37)
    at exports.loadConfig (/Users/josh/repos/mocha/lib/cli/config.js:78:24)
    at Suite.<anonymous> (/Users/josh/repos/mocha/test/integration/config.spec.js:25:16)
    at Object.create (/Users/josh/repos/mocha/lib/interfaces/common.js:153:19)
    at context.describe.context.context (/Users/josh/repos/mocha/lib/interfaces/bdd.js:46:27)
    at Suite.<anonymous> (/Users/josh/repos/mocha/test/integration/config.spec.js:22:3)
    at Object.create (/Users/josh/repos/mocha/lib/interfaces/common.js:153:19)
    at context.describe.context.context (/Users/josh/repos/mocha/lib/interfaces/bdd.js:46:27)
    at Object.<anonymous> (/Users/josh/repos/mocha/test/integration/config.spec.js:10:1)
    at Module._compile (node:internal/modules/cjs/loader:1692:14)
    at Object..js (node:internal/modules/cjs/loader:1824:10)
    at Module.load (node:internal/modules/cjs/loader:1427:32)
    at Module._load (node:internal/modules/cjs/loader:1250:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
    at Module.require (node:internal/modules/cjs/loader:1449:12)
    at require (node:internal/modules/helpers:135:16)
    at Object.requireModule [as requireOrImport] (/Users/josh/repos/mocha/lib/nodejs/esm-utils.js:98:12)
    at exports.loadFilesAsync (/Users/josh/repos/mocha/lib/nodejs/esm-utils.js:155:34)
    at Mocha.loadFilesAsync (/Users/josh/repos/mocha/lib/mocha.js:429:19)
    at singleRun (/Users/josh/repos/mocha/lib/cli/run-helpers.js:174:15)
    at exports.runMocha (/Users/josh/repos/mocha/lib/cli/run-helpers.js:247:10)
    at exports.handler (/Users/josh/repos/mocha/lib/cli/run.js:372:11)
    at /Users/josh/repos/mocha/node_modules/yargs/build/index.cjs:1:8993
    at /Users/josh/repos/mocha/node_modules/yargs/build/index.cjs:1:4949

@codecov
Copy link

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (410ce0d) to head (ac5c16f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5484   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          57       57           
  Lines        4465     4465           
  Branches      918      918           
=======================================
  Hits         4176     4176           
  Misses        289      289

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📦 Package: Bump strip-json-comments from 3 to 5

2 participants

@JoshuaKGoldberg @mark-wiemer