-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: bump log-symbols from 4 to 7 #5487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Good luck! |
|
Note to self: |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5487 +/- ##
==========================================
+ Coverage 93.52% 93.66% +0.13%
==========================================
Files 57 57
Lines 4465 4465
Branches 918 918
==========================================
+ Hits 4176 4182 +6
+ Misses 289 283 -6 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
| export async function resolve(specifier, context, defaultResolve) { | ||
| const extension = path.extname( | ||
| fileURLToPath(/**@type {import('url').URL}*/ (new URL(specifier, context.parentURL))), | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is unused and causes a different error on main vs. this branch. Same with #5482. πͺ
PR Checklist
status: accepting prsOverview
Similar to #5484, this increases the lockfile size for local development dependencies. This is
log-symbols@2is still referenced by:karmais tracked in π Repo: Stop using deprecatedkarmalibraryΒ #5253π