Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: normalized ESLint config to v9's recommended structure #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 2 commits into from
Dec 19, 2025
Merged

chore: normalized ESLint config to v9's recommended structure #5575

JoshuaKGoldberg merged 2 commits into from
Dec 19, 2025

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 18, 2025 •
edited
Loading

PR Checklist

Overview

Applies a few relatively recently introduced best practices to eslint.config.js:

  • Used the new defineConfig with extends to make it a little more straightforward to extend configs
  • Had every file group explicitly indicate its target files, to ignore the ESLint **/*.js-esque defaults
  • Removed unnecessary settings such as the default sourceType: "script"
  • Removed eslint-env comments that don't have any impact in flat config

...along with some general improvements:

@codecov
Copy link

codecov bot commented Dec 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (e1cf23c) to head (366bade).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5575   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          57       57           
  Lines        4465     4465           
  Branches      918      918           
=======================================
  Hits         4176     4176           
  Misses        289      289

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer
Copy link
Member

mark-wiemer commented Dec 19, 2025

@JoshuaKGoldberg please resolve conflicts, I just merged a different deps upgrade PR, this will be next in the merge queue :)

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7f9ed1f into mochajs:main Dec 19, 2025
81 checks passed
@github-actions github-actions bot mentioned this pull request Dec 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-wiemer mark-wiemer mark-wiemer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🛠 Repo: Enable ESLint's recommended rules for JS

2 participants

@JoshuaKGoldberg @mark-wiemer