Pass --clr-memory-model in csc/vbc wrapper script #16439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help with random CSC crashes on ARM (we've been using it in the Mono build for a while).
c5f5272 to
499ce21
Compare
Member
Author
|
@BrzVlad do you think this will have negative performance effect on amd64 platforms? |
Member
|
@akoeplinger No. It doesn't impact code generation in any way on strong memory model platforms |
lambdageek
approved these changes
Aug 23, 2019
Member
Author
|
@monojenkins backport 2019-08 |
monojenkins
added a commit
that referenced
this pull request
Aug 26, 2019
[2019-08] Pass --clr-memory-model in csc/vbc wrapper script Should help with random CSC crashes on ARM (we've been using it in the Mono build for a while). Backport of #16439. /cc @akoeplinger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with random CSC crashes on ARM (we've been using it in the Mono build for a while).