[android] remove text relocations in AOT/arm32 #16432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 223e0bd.
…ger assemblies on ARM (mono#14043)" This reverts commit 9ff3b0d.
vargaz
approved these changes
Aug 23, 2019
Contributor
Author
|
@monojenkins squash |
Contributor
Author
|
@monojenkins backport 2019-08 |
Contributor
Author
|
@radekdoulik @grendello how far do we need to backport this? The original change was landed up to |
Contributor
|
Current XA master uses 2019-06, so we would like to have it at least as far as that. d16-3 uses 2019-06 as well, d16-2 uses 2019-02 and supports Android Q as well, so I think 2019-02 would need it too. |
Contributor
Author
|
@monojenkins backport 2019-06 |
Contributor
Author
|
@monojenkins backport 2019-02 |
Contributor
Author
|
not sure if |
This was referenced Sep 4, 2019
lewurm
added a commit
to lewurm/mono
that referenced
this pull request
Sep 6, 2019
This reverts commit b6ca76c.
lewurm
added a commit
to lewurm/mono
that referenced
this pull request
Sep 9, 2019
This reverts commit b6ca76c.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Sep 9, 2019
This reverts commit b6ca76c.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Sep 9, 2019
This reverts commit b6ca76c.
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Sep 10, 2019
This reverts commit b6ca76c.
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
[android] remove text relocations in AOT/arm32 Remove support for "big assemblies" for AOT on Android running on ARM 32bit. This will remove relocations in `.text` which are not allowed in the upcoming Android Q release anymore. _If_ a customer should run into this problem, the suggested workarounds are: * Switch to ARM64, or * Do not use AOT compilation. Fixes mono/mono#16369 Commit migrated from mono/mono@b6ca76c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for "big assemblies" for AOT on Android running on ARM 32bit. This will remove relocations in
.textwhich are not allowed in the upcoming Android Q release anymore.If a customer should run into this problem, the suggested workarounds are:
Fixes #16369