Use the right FileSystemWatcher sources #16539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corefx code for FileSystemEventArgs has some changes to support constructing one with a null filename. Fixes mono#16486
Contributor
Author
|
We need this backported down to 2019-06 at least. |
Contributor
Author
Contributor
Author
|
@monojenkins commit csproj |
Contributor
|
@alexischr I added you as a reviewer. Please have a look |
alexischr
approved these changes
Aug 28, 2019
Contributor
|
@monojenkins build failed |
Contributor
Author
|
Based on https://dev.azure.com/devdiv/DevDiv/_workitems/edit/972836, 2019-02 is the target |
Contributor
|
@monojenkins backport 2019-08 |
Contributor
|
@monojenkins backport 2019-06 |
Contributor
|
@monojenkins backport 2019-02 |
This was referenced Aug 28, 2019
Contributor
|
@steveisok backporting to 2019-02 failed, the patch results in conflicts: Please backport manually! |
Contributor
Author
|
@steveisok should I do a manual backport to 2019-02? |
Member
|
@Therzok yes, please do |
Contributor
Author
This was referenced Sep 10, 2019
UnityAlex
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jun 2, 2022
* Use the right FileSystemWatcher sources The corefx code for FileSystemEventArgs has some changes to support constructing one with a null filename. Fixes mono#16486 * Remove the mono sources for the newly replaced files * [csproj] Update project files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corefx code for FileSystemEventArgs has some changes to support
constructing one with a null filename.
Fixes #16486