Add RenamedEvent* to FSW sources from CoreFX #16755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mono#16486 - This was only partially fixed until now
Contributor
Author
|
@monojenkins commit csproj |
This was referenced Sep 10, 2019
Contributor
Author
|
Also, where can I find the test suite to try and crop up a test case for this? |
Contributor
Author
|
@monojenkins commit csproj |
alexischr
approved these changes
Sep 10, 2019
Contributor
Author
|
@monojenkins backport 2019-08 |
Contributor
|
@Therzok backporting to 2019-02 failed, the patch results in conflicts: Please backport manually! |
Contributor
Author
|
I don't have push rights to the mono org to be able to modify the backport PRs. |
Contributor
Author
|
@monojenkins build failed |
Contributor
Author
|
@mononjenkins build failed |
Contributor
Author
|
cc @lewing we're going to need a bump of mono once this is merged. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Could you please also remove the old files |
Contributor
Author
|
Sorry, didn't see the notification. Pushed a new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16486 - This was only partially fixed until now
This is a continuation of #16539
Should we port all sources to corefx?