[2019-08] [aot] move method_addresses to data.rel.so section to avoid text relocations #16739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another revert of a revert! 🎉
After some discussions with @grendello and @radekdoulik, we came up with this solution. It's a better attempt to fix #16369 as it (1) works within the restrictions of Android 10 and (2) still works for armv7 AOT.
.textrelocations aren't allowed in Android 10 (and this change shouldn't hurt on Linux).AOT compilation:
Before:
After switching to
.data.rel.so:Backport of #16729.
/cc @marek-safar @lewurm