Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@chkn
Copy link
Contributor

@chkn chkn commented Nov 22, 2019

Fixes #16763

@dnfclas
Copy link

dnfclas commented Nov 22, 2019

CLA assistant check
All CLA requirements met.

@chkn
Copy link
Contributor Author

chkn commented Nov 22, 2019

@monojenkins build pkg

@chkn
Copy link
Contributor Author

chkn commented Nov 22, 2019

@monojenkins build pkg

@chkn
Copy link
Contributor Author

chkn commented Nov 23, 2019

@monojenkins build pkg

@nosami
Copy link
Member

nosami commented Nov 24, 2019

@chkn Looks like patches/fsharp-GetFileNameWithoutExtension-type-inference.patch is failing to apply

@chkn
Copy link
Contributor Author

chkn commented Nov 24, 2019

@monojenkins build pkg

@nosami
Copy link
Member

nosami commented Nov 24, 2019

@chkn patches/fsharp-msbuild-16-0.patch failed too 😫

patches/fsharp-portable-pdb.patch is required and I believe patches/fsharp-custom-prefix.patch is still required. Although thinking about it, we could just apply these to the mono/fsharp repo seeing as we own that?

@chkn
Copy link
Contributor Author

chkn commented Nov 24, 2019

@monojenkins build pkg

@chkn
Copy link
Contributor Author

chkn commented Nov 24, 2019

@nosami Good idea! Let's see if we can get this built properly first, and then we can look at cleaning things up

@chkn
Copy link
Contributor Author

chkn commented Nov 25, 2019

On second thought, fsharp-custom-prefix.patch failed too.. if it’s still needed, it might be easier to fix directly in mono/fsharp as you suggest

@nosami
Copy link
Member

nosami commented Nov 25, 2019

Looks like mono/config.make has diverged too much since the patch was created.

fsharp-msbuild-16-0.patch still looks to be needed too .. it's probably easiest to make the changes directly into the repo.

@nosami nosami mentioned this pull request Nov 26, 2019
@vshapenko
Copy link

Any update on this issue?

@nosami
Copy link
Member

nosami commented Mar 27, 2020

@vshapenko I'm taking another look at it now

@vshapenko
Copy link

I will explain, why i am worrying much about this. I am developing a mobile app using Fabulous. Current version of Fabulous requires FSharp version >= 4.6.2, which looks ok. So, using f# 4.7, currently i cannot build for ios using mac, only by scenario of pairing mac to visual studio.
And i understand, that with release of .net 5 this problem will fly away. If someone could guide where to dig to solve this problem, it would be amazing. As far as i understand, problem is into cmake+python build scripts for mono.

@KirillOsenkov
Copy link
Member

@marek-safar apologies for bringing so many issues to you, but we have this one which is very impactful for VSMac. A lot of VSMac users want to use the latest F# compiler features, but they can't because Mono is using an old compiler. Would it be possible to pick up this PR and update the F# compiler to latest in Mono?

Related community feedback:
https://developercommunity2.visualstudio.com/t/F-47-support/924698
https://developercommunity2.visualstudio.com/t/No-support-for-FSharpCore-47/1192676

@marek-safar
Copy link
Member

@steveisok could you get this completed and land it to 2020-02?

@steveisok
Copy link
Contributor

Seems the most up to date PR for this is #17925

I'll need to ping @nosami there and see what's left. At first glance, it seems there are some packaging problems.

@akoeplinger akoeplinger mentioned this pull request Oct 26, 2020
akoeplinger added a commit that referenced this pull request Oct 27, 2020
@akoeplinger akoeplinger deleted the fsharp47 branch November 3, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump F# to 4.7

8 participants