-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Bump to F# 5.0 #20511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to F# 5.0 #20511
Conversation
3759bd9 to
8d3a37d
Compare
8d3a37d to
69d3cbe
Compare
|
@monojenkins build pkg |
|
@KirillOsenkov I ran a simple helloworld F# app and that worked fine, do you have more sophisticated tests? |
|
@cartermp and I will try to take it for a spin today! Thank you so much! |
|
@mrward FYI |
|
This is amazing! Happy to help test it out as well 💯 |
KirillOsenkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with VSMac and compiles latest F# programs!
mrward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me This allows the ASP.NET Core empty and web api project templates for .NET 5 to be compiled in VS Mac.
|
I think with this line we can now officially retire https://github.com/fsharp/fsharp in favour of https://github.com/dotnet/fsharp. I'll discuss with the F# Software Foundation in that repo |
|
This is amazing work @akoeplinger . |
|
@akoeplinger Do you want to push any of those patches back to dotnet/fsharp? |
|
Also, is the bump of VSMac F# support going ok? Let me know if you hit any issues |
|
@akoeplinger awesome work! |
@dsyme we can do that but in dotnet/fsharp#10305 (comment) I read that the plan is to remove the desktop build of fcs so I wasn't sure if you want to take that change. |
|
Official build of the Mono .pkg based on 2020-02 can be found here: https://xamjenkinsartifact.azureedge.net/build-package-osx-mono/2020-02/113/970783731fccf269dcc3d2385bfd4adadf172196/MonoFramework-MDK-6.12.0.106.macos10.xamarin.universal.pkg |
|
@akoeplinger Do you know when this will be released? Tested with your link and it compiles and runs fine, even though VSfM is not happy about it. |
|
@TimLariviere You should be able a later Mono 6.12 with VS Mac 8.8 now. Why is VS Mac not happy about it? I am using Mono 6.12.0.107. There is a PR pending for Mono 6.12.0.107 to be included with VS Mac 8.8. It should be in a service release at some point for VS Mac. |
|
@mrward Indeed. Mono 6.12.0.107 is available on the preview channel. Same with Versions
=== Visual Studio Enterprise 2019 for Mac (Preview) === Version 8.9 Preview (8.9 build 265) === Mono Framework MDK === Runtime: === Roslyn (Language Service) === 3.9.0-1.20507.6+4ed928935ce0e5db4327c168dfdad1c820a6a490 === NuGet === Version: 5.8.0.6860 === .NET Core SDK === SDK: /usr/local/share/dotnet/sdk/5.0.100/Sdks === .NET Core Runtime === Runtime: /usr/local/share/dotnet/dotnet === .NET Core 3.1 SDK === SDK: 3.1.403 === Xamarin.Profiler === Version: 1.6.15.68 === Updater === Version: 11 === Xamarin.Android === Version: 11.1.99.168 (Visual Studio Enterprise) SDK Tools Version: 26.1.1 Build Information: === Microsoft OpenJDK for Mobile === Java SDK: /Users/timothelariviere/Library/Developer/Xamarin/jdk/microsoft_dist_openjdk_1.8.0.25 === Android SDK Manager === Version: 16.9.0.11 === Android Device Manager === Version: 16.9.0.8 === Xamarin Designer === Version: 16.9.0.10 === Apple Developer Tools === Xcode 12.2 (17535) === Xamarin.Mac === Version: 6.22.1.27 (Visual Studio Enterprise) === Xamarin.iOS === Version: 14.7.0.166 (Visual Studio Enterprise) === Build Information === Release ID: 809000265 === Operating System === Mac OS X 10.16.0 |
|
Yes, now we need to also update the language service from FSharp.Compiler.Service 34.1.0 to 38.0.0. Unfortunately I doubt we can do this in a service release. But at least this gives you IDE support for features up to 34.1.0 which was 9 months ago. |
|
@cartermp FYI ^^ |
Fixes #16763
Closes #17925
Closes #17882