Fix boehm on Windows i386 builds #17901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After mono#16832 was merged the run-msbuild.bat script has an additional required parameter for specifying the GC. However the script only passed the MONO_TARGET_GC property to msbuild if the script had no additional parameters which doesn't make sense. Always pass the parameter, this should fix the boehm build on Windows i386.
vargaz
approved these changes
Nov 25, 2019
lateralusX
approved these changes
Nov 25, 2019
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
After mono/mono#16832 was merged the run-msbuild.bat script has an additional required parameter for specifying the GC. However the script only passed the MONO_TARGET_GC property to msbuild if the script had no additional parameters which doesn't make sense. Always pass the parameter, this should fix the boehm build on Windows i386. Commit migrated from mono/mono@bdf4790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #16832 was merged the run-msbuild.bat script has an additional required parameter for specifying the GC.
However the script only passed the MONO_TARGET_GC property to msbuild if the script had no additional parameters which doesn't make sense.
Always pass the parameter, this should fix the boehm build on Windows i386.