Replace embedded libgc with Unity fork of recent Boehm (bdwgc) #16832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
approved these changes
Sep 14, 2019
Contributor
|
RIP. |
Contributor
|
@monojenkins build failed |
Contributor
|
Some lanes fail because of: An empty rule needs to be added to libgc/Makefile.am: |
CoffeeFlux
reviewed
Sep 17, 2019
c441252 to
b21a35f
Compare
Contributor
|
@monojenkins build failed |
Contributor
|
/azp run |
|
Pull request contains merge conflicts. |
Contributor
Author
|
Shall I squash, rebase, and fix a few of the commented areas? |
This reverts commit 1f90d81.
…sing mono symbols not to be exported.
75f9841 to
c4ec57d
Compare
lateralusX
suggested changes
Nov 22, 2019
Member
lateralusX
left a comment
There was a problem hiding this comment.
Looks like scripts/ci/pipeline-netcore-runtime.yml is also using run-msbuild.bat, so needs the additional argument.
Member
|
@lateralusX looks like the build still worked: https://dev.azure.com/dnceng/public/_build/results?buildId=435839&view=logs. Probably because it explicitly passes I can fix this up if you think it's important in my other PR so we can get this finally in :) |
Contributor
|
@monojenkins build failed |
Member
|
@akoeplinger OK lets fix that in your upcoming PR then. |
lateralusX
approved these changes
Nov 22, 2019
akoeplinger
added a commit
to akoeplinger/mono
that referenced
this pull request
Nov 25, 2019
After mono#16832 was merged the run-msbuild.bat script has an additional required parameter for specifying the GC. However the script only passed the MONO_TARGET_GC property to msbuild if the script had no additional parameters which doesn't make sense. Always pass the parameter, this should fix the boehm build on Windows i386.
Contributor
|
Is it intended for |
Member
|
that doesn't look right, I assume we didn't do this for the old Boehm GC as part of make install, so should probably be excluded in updated version as well. |
akoeplinger
added a commit
that referenced
this pull request
Nov 25, 2019
After #16832 was merged the run-msbuild.bat script has an additional required parameter for specifying the GC. However the script only passed the MONO_TARGET_GC property to msbuild if the script had no additional parameters which doesn't make sense. Always pass the parameter, this should fix the boehm build on Windows i386.
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
…mono#16832) * Initial commit to migrate libgc to bdwgc. * Fix submodule url * Don't force Boehm as runtime wrapper. Was just for testing locally. * Build bdwgc as single object file. Helps with performance. * Bump bdwgc submodule. * Attempt to fix windows MSVC based build. * Remove any references to GC_INSIDE_DLL as we manually managed threads on Windows. * Allow building boehm on Windows amd64. * Allow building boehm with msvc. * Bump bdwgc to fix line endings * Use LF for sh, am, m4, and ac files in bdwgc * Bump bdwgc & libatomic_ops with fix for cygwin * Bump bdwgc to fix mono-boehm being generated as libtool wrapper script. * Link the static boehm library. * Revert "Link the static boehm library." This reverts commit mono/mono@1f90d81. * Use --export-all-symbols on cygwin/mingw to fix issues with boehm causing mono symbols not to be exported. * Fix Commit migrated from mono/mono@cc13723
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
After mono/mono#16832 was merged the run-msbuild.bat script has an additional required parameter for specifying the GC. However the script only passed the MONO_TARGET_GC property to msbuild if the script had no additional parameters which doesn't make sense. Always pass the parameter, this should fix the boehm build on Windows i386. Commit migrated from mono/mono@bdf4790
|
Is the unity fork better? Why replace? |
Contributor
|
It is better, and mono doesn't really use it anymore, the main user is unity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.