[eglib] Don't define _FORTIFY_SOURCE on Cygwin builds #18308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See msys2/MINGW-packages#5803 Without -lssp (or -fstack-protector), -D_FORTIFY_SOURCE=2 leads to linker errors.
Member
Author
|
Another option is to:
|
baulig
approved these changes
Dec 27, 2019
Member
Author
|
@monojenkins backport to 2019-12 |
This was referenced Dec 27, 2019
Member
|
This is correct fix, I had this fix done in a different repro a couple of months ago, waiting on the bigger merge of #16832 to go live before merging it in, but unfortunately it never got into master and was forgotten (sine we didn't see any issues on CI due to keeping older cygwin tooling). Great that you identified and fixed the issue, removing the dependency on older cygwin tooling. |
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
See msys2/MINGW-packages#5803 Without -lssp (or -fstack-protector), -D_FORTIFY_SOURCE=2 leads to linker errors. Commit migrated from mono/mono@61eb2be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See msys2/MINGW-packages#5803
Without -lssp (or -fstack-protector), -D_FORTIFY_SOURCE=2 leads to linker
errors.
Fixes #18287