Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kjpou1
Copy link
Contributor

@kjpou1 kjpou1 commented Apr 7, 2020

Configure WASM to not disable IO portability. WebAssembly runtime can run on windows or *nix type of files systems. With turning on the IO portability we can attempt to support both nomenclatures.

fixes: #18933

kjpou1 added 2 commits April 7, 2020 12:18
- enable IO portability to support both windows and unix type file paths.
- With the portability of drive set via the environment variable MONO_IOMAP the PATH information can be handled using unix or windows naming conventions.
@kjpou1 kjpou1 requested review from kg, lewing and vargaz April 7, 2020 10:25
@kjpou1 kjpou1 changed the title [wasm] Webassembly IO Portability [wasm] WebAssembly IO Portability Apr 7, 2020
@kjpou1 kjpou1 requested a review from baulig April 7, 2020 10:26
@kjpou1
Copy link
Contributor Author

kjpou1 commented Apr 7, 2020

@monojenkins build Linux i386

@kjpou1
Copy link
Contributor Author

kjpou1 commented Apr 7, 2020

@monojenkins build Linux WebAssembly

@kjpou1
Copy link
Contributor Author

kjpou1 commented Apr 7, 2020

@monojenkins build Windows x64 FullAOT+LLVM

- This will set only the Alt Directory Separator Char.
- Setting this variable to "drive" causes tests to fail.
@kjpou1
Copy link
Contributor Author

kjpou1 commented Apr 8, 2020

@monojenkins build Linux AArch64 Coop Suspend

@kjpou1 kjpou1 marked this pull request as ready for review April 8, 2020 10:04
@kjpou1
Copy link
Contributor Author

kjpou1 commented Apr 8, 2020

@monojenkins build Windows x64 FullAOT+LLVM

@baulig
Copy link
Contributor

baulig commented Apr 8, 2020

According to the man page, MONO_IOMAP is deprecated and no longer works with Mono 6.0.

Instead of setting the environment variable, I think it'd be better to completely disable it by adding a compiler conditional for WASM to the code.

@vargaz
Copy link
Contributor

vargaz commented Apr 8, 2020

io portability is for running legacy .net apps on mono, its not really relevant for webassembly.

@kjpou1
Copy link
Contributor Author

kjpou1 commented Apr 9, 2020

Perfect will do. Thanks

@kjpou1
Copy link
Contributor Author

kjpou1 commented Apr 9, 2020

closed in favor of #19488

@kjpou1 kjpou1 closed this Apr 9, 2020
@kjpou1 kjpou1 deleted the wasm-io-portability branch April 13, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.IO.Path.GetFileName doesn't work in client-side Blazor wasm

3 participants