[wasm][bcl] Handle correctly backslash in file name #19488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify IO file to assign backslash to alternate directory separator by default - Add tests for issue mono#18933
Member
|
I like that the scope of this is much more limited. |
kg
approved these changes
Apr 9, 2020
Contributor
Author
|
Not exactly sure what to do with these tests. Would these be considered portability and we should skip? Skipped the tests failing:
|
- After internal discussions decided to skip these two tests on wasm 1. GetDirectories_Backslash 1. GetFiles_Backslash
- skip subtest mono#9 if WASM - To fix issue mono#18933 we set the AltDirectorySeparatorChar as well. This causes the `Assert.IsTrue (!Path.IsPathRooted ("\\"), "IsPathRooted mono#9");` to fail. Path.IsPathFullyQualified Method handles paths that use both the DirectorySeparatorChar and the AltDirectorySeparatorChar characters.
- skip if WASM
Contributor
Author
|
@monojenkins build OS X x64 |
Contributor
Author
|
@monojenkins build Linux ARMv7 Interpreter |
steveisok
approved these changes
Apr 10, 2020
Contributor
Author
|
@monojenkins build Windows x64 FullAOT |
Member
|
@monojenkins backport 3.2-wasm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #18933