Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[System.Runtime.Serialization] Work around specified cast is not valid #19620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steveisok merged 1 commit into from
Apr 23, 2020
Merged

[System.Runtime.Serialization] Work around specified cast is not valid #19620

steveisok merged 1 commit into from
Apr 23, 2020

Conversation

@mdh1418
Copy link
Contributor

@mdh1418 mdh1418 commented Apr 21, 2020 •
edited
Loading

Fixes #19466

It was discovered that the specified cast is not valid was being thrown because of an attempt to cast an object of type ResourceType as XmlDictionaryString. However, ResourceType is of type Enum, so instead a check for type XmlDictionaryString is performed before resorting to getting the object's name via ToString().

To test code changes, I needed to side install msbuild into my mono install via
make -j in <msbuild_repo>
<msbuild_repo>/install-mono-prefix.sh <local-mono-install>
And then in the Wasm project directory
<local-mono-install>/bin/msbuild Wasm.csproj

Steps to reproduce:

$ dotnet new -i Microsoft.AspNetCore.Components.WebAssembly.Templates::3.2.0-preview3.20168.3
$ dotnet new blazorwasm -o Wasm
$ cd Wasm
$ msbuild Wasm.csproj

output before

"/Users/mdhwang/Wasm/Wasm.csproj" (default target) (1) ->
(_GenerateBlazorBootJson target) ->
  /Users/mdhwang/.nuget/packages/microsoft.aspnetcore.components.webassembly.build/3.2.0-preview3.20168.3/targets/Blazor.MonoRuntime.targets(348,5): error : Specified cast is not valid. [/Users/mdhwang/Wasm/Wasm.csproj]

    0 Warning(s)
    1 Error(s)

Output after code changes

Wasm (Blazor output) -> /Users/mdhwang/Wasm/bin/Debug/netstandard2.1/wwwroot
Done Building Project "/Users/mdhwang/Wasm/Wasm.csproj" (default targets).

Build succeeded.
    0 Warning(s)
    0 Error(s)

@mdh1418 mdh1418 force-pushed the mdhwang/msbuild_blazor_issue branch from 0dd2a4a to 65c2e66 Compare April 21, 2020 19:28
@rodrmoya
Copy link
Contributor

rodrmoya commented Apr 22, 2020

@monojenkins build pkg

@steveisok steveisok merged commit 946a479 into mono:master Apr 23, 2020
@steveisok
Copy link
Contributor

steveisok commented Apr 23, 2020

@monojenkins backport 2020-02

@steveisok
Copy link
Contributor

steveisok commented Apr 23, 2020

@monojenkins backport 2019-12

@mdh1418 mdh1418 deleted the mdhwang/msbuild_blazor_issue branch April 23, 2020 13:02
This was referenced Apr 23, 2020
Merged
Merged
@rodrmoya
Copy link
Contributor

rodrmoya commented Apr 23, 2020

This fixes the issue for vsmac 👍

akoeplinger pushed a commit that referenced this pull request Apr 24, 2020
@monojenkins
[System.Runtime.Serialization] Work around `specified cast is not val…
83558de 
…id` error (#19640)

Backport of #19620.
akoeplinger pushed a commit that referenced this pull request Apr 24, 2020
@monojenkins
[System.Runtime.Serialization] Work around `specified cast is not val…
c8cfa8f 
…id` error (#19641)

Backport of #19620.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@steveisok steveisok Awaiting requested review from steveisok

+1 more reviewer

@rodrmoya rodrmoya rodrmoya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mono's msbuild can't build Blazor WASM projects

4 participants

@mdh1418 @rodrmoya @steveisok @akoeplinger