Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2019-12] [System.Runtime.Serialization] Work around specified cast is not valid #19641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 1 commit into from
Apr 24, 2020
Merged

[2019-12] [System.Runtime.Serialization] Work around specified cast is not valid #19641

akoeplinger merged 1 commit into from
Apr 24, 2020

Conversation

@monojenkins
Copy link
Contributor

@monojenkins monojenkins commented Apr 23, 2020

Fixes #19466

It was discovered that the specified cast is not valid was being thrown because of an attempt to cast an object of type ResourceType as XmlDictionaryString. However, ResourceType is of type Enum, so instead a check for type XmlDictionaryString is performed before resorting to getting the object's name via ToString().

To test code changes, I needed to side install msbuild into my mono install via
make -j in <msbuild_repo>
<msbuild_repo>/install-mono-prefix.sh <local-mono-install>
And then in the Wasm project directory
<local-mono-install>/bin/msbuild Wasm.csproj

Steps to reproduce:

$ dotnet new -i Microsoft.AspNetCore.Components.WebAssembly.Templates::3.2.0-preview3.20168.3
$ dotnet new blazorwasm -o Wasm
$ cd Wasm
$ msbuild Wasm.csproj

output before

"/Users/mdhwang/Wasm/Wasm.csproj" (default target) (1) ->
(_GenerateBlazorBootJson target) ->
  /Users/mdhwang/.nuget/packages/microsoft.aspnetcore.components.webassembly.build/3.2.0-preview3.20168.3/targets/Blazor.MonoRuntime.targets(348,5): error : Specified cast is not valid. [/Users/mdhwang/Wasm/Wasm.csproj]

    0 Warning(s)
    1 Error(s)

Output after code changes

Wasm (Blazor output) -> /Users/mdhwang/Wasm/bin/Debug/netstandard2.1/wwwroot
Done Building Project "/Users/mdhwang/Wasm/Wasm.csproj" (default targets).

Build succeeded.
    0 Warning(s)
    0 Error(s)

Backport of #19620.

/cc @steveisok @mdh1418

@monojenkins monojenkins added this to the 2019-12 (6.10.xx) milestone Apr 23, 2020
@rodrmoya
Copy link
Contributor

rodrmoya commented Apr 23, 2020

@monojenkins build pkg

rodrmoya
rodrmoya approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@rodrmoya rodrmoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this also works perfectly, so :shipit: :)

@akoeplinger akoeplinger merged commit c8cfa8f into mono:2019-12 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

2 more reviewers

@steveisok steveisok steveisok approved these changes

@rodrmoya rodrmoya rodrmoya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2019-12 (6.10.xx)

Development

Successfully merging this pull request may close these issues.

5 participants

@monojenkins @rodrmoya @steveisok @akoeplinger @mdh1418