[wasm] Fix the handling of i8/u8 in get_wrapper_shared_type_full (). #19859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these were returned verbatim, which caused sharing issues when the type had attributes. Fixes mono#19841.
|
@monojenkins build failed |
BrzVlad
approved these changes
May 28, 2020
BrzVlad
pushed a commit
to BrzVlad/mono
that referenced
this pull request
Aug 17, 2022
…ono#19859) Previously, these were returned verbatim, which caused sharing issues when the type had attributes. Fixes mono#19841.
akoeplinger
pushed a commit
that referenced
this pull request
Aug 18, 2022
…#21537) * [wasm] Fix the handling of i8/u8 in get_wrapper_shared_type_full (). (#19859) Previously, these were returned verbatim, which caused sharing issues when the type had attributes. Fixes #19841. * [aot] Fix the handling of r4/r8 parameter types with attributes during generic sharing. (#20217) The attributes need to be ignored as with the other types, otherwise gsharedvt wrappers for signatures with parameters like double f = default will not be found. Fixes #20195. Co-authored-by: Zoltan Varga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19837.