[aot] Fix the handling of r4/r8 parameter types with attributes during generic sharing. #20217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g generic sharing. The attributes need to be ignored as with the other types, otherwise gsharedvt wrappers for signatures with parameters like double f = default will not be found. Fixes mono#20195.
Contributor
Author
|
@monojenkins build failed |
|
should the method get_wrapper_shared_type_reg consider this bug also? mono/mono/mini/mini-generic-sharing.c Lines 1343 to 1371 in 1ae5414 I found it also do't consider the r4/r8 type. |
Contributor
Author
|
It calls the other function. |
|
but it is also not handling r4/r8 parameter types, it can't be a problem? |
Member
|
I deleted a bunch of duplicate comments (maybe a github bug?) |
jeromelaban
added a commit
to unoplatform/Uno.Wasm.MonoRuntime
that referenced
this pull request
Aug 7, 2020
CoffeeFlux
approved these changes
Aug 10, 2020
Member
|
/backport to 2020-02 |
Contributor
|
Started backporting to 2020-02: https://github.com/mono/mono/actions/runs/2875839291 |
Contributor
|
@BrzVlad backporting to 2020-02 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [aot] Fix the handling of r4/r8 parameter types with attributes during generic sharing.
Using index info to reconstruct a base tree...
M mono/mini/mini-generic-sharing.c
Falling back to patching base and 3-way merge...
Auto-merging mono/mini/mini-generic-sharing.c
CONFLICT (content): Merge conflict in mono/mini/mini-generic-sharing.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [aot] Fix the handling of r4/r8 parameter types with attributes during generic sharing.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
BrzVlad
pushed a commit
to BrzVlad/mono
that referenced
this pull request
Aug 17, 2022
…g generic sharing. (mono#20217) The attributes need to be ignored as with the other types, otherwise gsharedvt wrappers for signatures with parameters like double f = default will not be found. Fixes mono#20195.
akoeplinger
pushed a commit
that referenced
this pull request
Aug 18, 2022
…#21537) * [wasm] Fix the handling of i8/u8 in get_wrapper_shared_type_full (). (#19859) Previously, these were returned verbatim, which caused sharing issues when the type had attributes. Fixes #19841. * [aot] Fix the handling of r4/r8 parameter types with attributes during generic sharing. (#20217) The attributes need to be ignored as with the other types, otherwise gsharedvt wrappers for signatures with parameters like double f = default will not be found. Fixes #20195. Co-authored-by: Zoltan Varga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attributes need to be ignored as with the other types, otherwise gsharedvt wrappers for signatures with
parameters like double f = default will not be found.
Fixes #20195.