[runtime] Avoid using guard pages for detecting stack overflow on macos #10896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS Mojave, it seems that changing the mapping of stack pages can lead to corruption bugs. mono#10802
For now we do it on the altstack which can be problematic.
Member
Author
|
@vargaz what are your thoughts on this ? |
kumpera
reviewed
Oct 1, 2018
Contributor
kumpera
left a comment
There was a problem hiding this comment.
I wonder if we should just disable MONO_ARCH_SIGSEGV_ON_ALTSTACK for OSX instead of this.
| * We don't do soft stack overflow handling. Do our best here. | ||
| * FIXME Don't do it in signal handler | ||
| */ | ||
| mono_sigctx_to_monoctx (ctx, &mctx); |
Contributor
There was a problem hiding this comment.
Hard stack overflow should always abort. This will 99.999% lead to a secondary abort that will hide the actual issue.
Contributor
|
I think only the main thread has issues, the other threads should be fine. |
Member
Author
Contributor
|
Probably, without guard pages its hard to cleanly detect and handle the overflow. |
Contributor
|
Hard stack overflow should be fatal, if we have code that tried anything but to crash, we should change it. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.