[runtime] Disable stack guard for main thread on osx #10899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS Mojave, it seems that changing the mapping of stack pages for main thread can lead to corruption bugs. mono#10802
vargaz
approved these changes
Oct 1, 2018
Member
|
@BrzVlad please backport to at least 2018-08 |
Contributor
|
We'll need this in 2018-04 (for 15-9) as well. |
Contributor
|
@monojenkins backport to 2018-08 |
Contributor
|
@monojenkins backport to 2018-06 |
Contributor
|
@monojenkins backport to 2018-04 |
This was referenced Oct 1, 2018
Contributor
|
@monojenkins backport to 2018-10 |
|
Do you have news for this problem? I'm surprised to see that a stable version of Xamarin.MAC 5.0 was put when there is this BIG problem .... |
Contributor
|
@Rogister If you looked above, you'd see multiple PR with a fix propagating to the various mono release branches. At some point after they land, we'll bump Xamarin.Mac to use them and if it passes QA release that as a fix. If you have a Xamarin.Mac question, please reply to the original macios issue or on the forums. The mono issue tracker isn't the place for discussing XM release priorities. |
monojenkins
added a commit
that referenced
this pull request
Oct 3, 2018
[2018-06] [runtime] Disable stack guard for main thread on osx Backport of #10899. /cc @luhenry @BrzVlad Description of #10899: On macOS Mojave, it seems that changing the mapping of stack pages for main thread can lead to corruption bugs. #10802 <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number -->
monojenkins
added a commit
that referenced
this pull request
Oct 3, 2018
[2018-08] [runtime] Disable stack guard for main thread on osx Backport of #10899. /cc @luhenry @BrzVlad Description of #10899: On macOS Mojave, it seems that changing the mapping of stack pages for main thread can lead to corruption bugs. #10802 <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number -->
monojenkins
added a commit
that referenced
this pull request
Oct 3, 2018
[2018-10] [runtime] Disable stack guard for main thread on osx Backport of #10899. /cc @luhenry @BrzVlad Description of #10899: On macOS Mojave, it seems that changing the mapping of stack pages for main thread can lead to corruption bugs. #10802 <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number -->
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
On macOS Mojave, it seems that changing the mapping of stack pages for main thread can lead to corruption bugs. mono/mono#10802 Commit migrated from mono/mono@9182bcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS Mojave, it seems that changing the mapping of stack pages for main thread can lead to corruption bugs.
#10802