Support asynchronous handlers of HttpApplication.EndRequest event. #12104
Conversation
|
|
|
Microsoft.Owin.Host.SystemWeb code that uses async EndRequest handler: |
|
approve |
|
Some tests are broken. Looking into it |
e37da2b to
8a446dd
Compare
|
I still see some test failures but I'm not sure that they are related to this PR. E.g., some tests for System.Net failed, but tests for System.Web pass |
Mono used to invoke the handler but not to wait for it to finish. Microsoft.Owin.Host.SystemWeb relies on async EndRequest event handler in order to manage Owin Context's lifecycle. Failure to await handler completion causes race conditions. This fixes mono#12103
8a446dd to
9857891
Compare
|
Rebased changes against current master. |
|
@monojenkins build failed |
|
Any news on this? We are using own patched version of Mono in production because of this. |
|
Hi, Yes this really a must have to support OWIN - adding support for it would be great. |
|
@marek-safar If we're going to merge #12619, then this PR can be closed since it's fixed there. |
|
I'd prefer landing #12619 instead |
|
Since the other PR essentially supersedes this one, I'm going to close. |
Mono used to invoke the handler but not wait for it to finish.
Microsoft.Owin.Host.SystemWeb relies on async EndRequest event handler in order to manage Owin Context's lifecycle. Failure to await handler completion causes race conditions.
Fixes #12103