@steveisok this will be quite hard to review and it broke some of existing tests. I'd propose to split this PR into few smaller ones (e.g. build infrastructure improvements, msbuild changes, etc) and also leave the files removal to separate PR

I'll try and break this out as much as I can. Outside of builds / deletes, I'm not sure how to spoon feed this?

As far as I can see, there are 2 System.Web.Extensions standalone tests that are failing. I'm working through getting that right.

Created an issue for the linux test failures that remain. #12676

@monojenkins build Linux x64

@monojenkins build OS X i386

@monojenkins build Linux x64 Interpreter

@steveisok if you haven't found the AOT build errors yet, here's some(?) of it:

// Error(s) in file /mnt/jenkins/workspace/test-mono-pull-request-amd64-fullaot/mcs/class/System.Web.Services/mobile_System.Web.Services.dll.sources:
Directory does not exist: '/mnt/jenkins/workspace/test-mono-pull-request-amd64-fullaot/mcs/class/System.Web/System.Web.Util'
Directory does not exist: '/mnt/jenkins/workspace/test-mono-pull-request-amd64-fullaot/mcs/class/System.Web/System.Web.Util'
File does not exist: '/mnt/jenkins/workspace/test-mono-pull-request-amd64-fullaot/mcs/class/System.Web/System.Web/HttpUtility.cs'
// gensources produced 3 error(s) and a set of 147 filename(s)

(This is from the Linux x64 FullAOT build)

You can reproduce what it's doing locally by doing a build with ./autogen.sh --with-runtime-preset=fullaot

(in general, the CI configurations are driven by <gitroot>/scripts/ci/run-jenkins.sh with various values in the CI_TAGS environment variables)

@monojenkins build Windows i386

PR update - I'm looking into the interpreter failures as there are crashes in generally the same 3 spots. The windows failures look to be flakes that pass/fail on and off. I'll take a closer look unless this is a known type of thing?

Finally, @marek-safar, I'm having a hard time coming up with ways to split this PR up and still be effective. In my view, it's pretty intertwined and I'm not sure there are many parts that can just stand on their own.

Please advise on what, if anything, you would like me to do.

I think the changes to System.Security, System.Web.Services, System.Data.Linq could be extracted

@monojenkins build Linux x64 Interpreter

@akoeplinger for me the change is ready for the merge, what do you think?

@marek-safar it looks generally good (found a few minor things while skimming the code, didn't do a full review yet).

The main issue is the reverse-engineered files like mcs/class/System.Web/resources/WebForms.js, they were supposed to be added to reference source: microsoft/referencesource#96.

We should sync with Immo this week and see whether we can get some movement there.

@monojenkins build failed

OK - revisiting this :-)

There are 5 test failures in System.Configuration that have to do w/ user.config (LocalFileSettingsProvider):

• ApplicationSettingsBaseTest.CustomClass_Roundtrip
• ApplicationSettingsBaseTest.ModifiedObjectsAreSerialized_Bug15818
• ApplicationSettingsBaseTest.Reset_FiresPropChangedOnly_Bug15818
• ApplicationSettingsBaseTest.SettingSavingEventFired_Bug2315
• ApplicationSettingsBaseTest.TestBug8533ConfHandlerWronglyMixedUp

The interesting thing is it works on my machine (tm). Note part of the xml I plucked out of user.config:

<MonoTests.System.Configuration.ApplicationSettingsBaseTest_x002B_Bug15818Settings2>
            <setting name="MyObject" serializeAs="Xml">
                <value>
                    <Bug15818Class xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
                        <Name>xyz</Name>
                        <Value>-1</Value>
                    </Bug15818Class>
                </value>
            </setting>
            <setting name="Text" serializeAs="String">
                <value>bla</value>
            </setting>
        </MonoTests.System.Configuration.ApplicationSettingsBaseTest_x002B_Bug15818Settings2>

If they work outside of CI, perhaps skipping them would be appropriate (for now)?

Hi,

Is there a time frame for this PR getting merged and released? I have run into 3 issues that this would resolve:

1. Issue Error CS1576 with mono and System.Web.Hosting.VirtualPathProvider  #13993
2. Implementation differences in System.Web.HostingEnvironment (constructor throws an exception): referencesource vs mono
3. Implementation differences in System.Web.HttpCookie#Value: referencesource vs mono

Really appreciate all the hard work on mono!

@adrianluisgonzalez As soon as I can solve why 5 test failures are inexplicably happening on our windows CI lane. They don't happen both locally (works on my machine!) and when I try it directly on our actual CI machines.

Really looking forward to this getting merged and released as it definitely fixes a few issues I have encountered.

Great work!

Any headway made on this PR? Eager for this to make it into a release.

Blocked on 5 System.Configuration failures on Windows that I cannot reproduce except on CI :-(. And I haven't had time to try to hone in on it.

Good thing is, rebasing against master just works, so it's not too stale ;-)

Appreciate the quick response! At least the merge back in is easy :p

Hope you and your family are well!