[WIP] System.Web.Extensions additions #21247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
267945a to
0ad7b0c
Compare
Contributor
|
@deltragon Thanks for opening this up! If you want, take a look at #12619 . I believe it'll have the tests that go along w/ your PR. |
2055f17 to
1f4f897
Compare
Author
|
@steveisok Thank you for the pointer! I also tried the approach of porting the whole thing to referencesource, but quickly gave up on it. Good to see that someone already put in that work :) |
1f4f897 to
b0a70dc
Compare
added 14 commits
November 21, 2021 20:21
… dependant changes (missing test)
…amed properties (missing test)
…lue additions (missing test)
…e repo (missing test)
…ns (missing test)
…riptor from referencesource
b0a70dc to
9e5e493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I am administrating a legacy ASP.NET project that is built on telerik web ui which makes heavy use of System.Web.Extensions.
These patches make it possible to run the project on mono/linux, which is what I would prefer to do with this project in the long term.
(I have not tested the project extensively yet, but it appears to load all pages/data so far.
The only issue seems to be that the encoding is not properly sent in the).Content-Typeheader, so the browser interprets UTF-8 as some legacy encodingI would like to contribute these patches to upstream mono.
They mostly consist of switching to/adding files from the referencesource, or (specifically for
System.Web.UI.ScriptManager) copy-pasting needed methods from the referencesource.I have some questions however:
System.Data.LinqDataViewand extendSystem.ComponentModel.DateTimeConverter, both based on the referencesource. Is it correct to just modify the mono/corefx repo?System.Data.LinqDataViewchanges might make sense as a separate PR.Other notes:
There is one commit switching from corefx back to the referencesource (Functionality has been added to corefx.System.ComponentModel.DateTimeConverter), as the referencesource version has methods corefx is missing. I will add the missing functionality to corefx instead.This does not pass the test suite forSystem.Web. I am currently working on that.