System.Web.HttpResponse: fix default encoding #21415
Open
+76
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I am not sure if the CI failures are my fault? If they are, I don't understand the output properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #21247, as it is a separate simple change and also fixes a bug.
By default, .NET does not append the charset to the Content-Type header if the response is empty. This was corrected in mono in #866.
However, as soon as any content is written to the response, it should append the charset. When just using
HttpResponse.Write(), this defaults to utf-8.(Note: I reverse-engineered this behavior from the referencesource.)
This PR fixes this behavior, and adds an additional testcase for the non-empty response.
This testcase has not been run on windows/.NET, as I do not have mono set up there. Does someone else need to check if this test passes on .NET or is this checked as part of CI?
Fixes https://bugzilla.xamarin.com/23/23810/bug.html