Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): let router handle internal redirects within middleware #18445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix(nuxt): let router handle internal redirects within middleware #18445

merged 2 commits into from
Jan 23, 2023

Conversation

@danielroe
Copy link
Member

@danielroe danielroe commented Jan 23, 2023 •
edited
Loading

🔗 Linked issue

resolves #15407, resolves #15738

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When we redirect within middleware, we need to tell vue router not to finish the route navigation or the page will load after all (on server side). This wasn't affecting the response but it was allowing forbidden routes to be hit on server side, and causing some unexplained errors in server logs.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 January 23, 2023 10:35
@danielroe danielroe self-assigned this Jan 23, 2023
@codesandbox
Copy link

codesandbox bot commented Jan 23, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel vercel bot temporarily deployed to Preview January 23, 2023 10:40 Inactive
@danielroe danielroe mentioned this pull request Jan 23, 2023
Closed
pi0
pi0 reviewed Jan 23, 2023
View reviewed changes
@danielroe danielroe changed the title fix(nuxt): let vue router handle internal redirects within middleware fix(nuxt): let router handle internal redirects within middleware Jan 23, 2023
@danielroe danielroe merged commit de4086f into main Jan 23, 2023
@danielroe danielroe deleted the fix/mw-redirections branch January 23, 2023 11:18
@lukaszflorczak lukaszflorczak mentioned this pull request Jan 23, 2023
Closed
@danielroe danielroe mentioned this pull request Jan 24, 2023
Merged
@ydnar
Copy link

ydnar commented Jan 26, 2023

This change seems to break route middleware that strips trailing slashes, e.g. /about/ → /about, which match the same destination route. SSR emits status code 301 (or 302), but responds with content and no Location header.

@TheAlexLichter
Copy link
Member

TheAlexLichter commented Jan 26, 2023

This change seems to break route middleware that strips trailing slashes, e.g. /about/ → /about, which match the same destination route. SSR emits status code 301 (or 302), but responds with content and no Location header.

Please create a new issue with reproduction then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels

bug ❗ p4-important

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client Component setup runs before router middleware is resolved

5 participants

@danielroe @ydnar @TheAlexLichter @pi0