Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(nuxt): await async callWithNuxt calls #18443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix(nuxt): await async callWithNuxt calls #18443

merged 2 commits into from
Jan 23, 2023

Conversation

@danielroe
Copy link
Member

@danielroe danielroe commented Jan 23, 2023

🔗 Linked issue

#15738

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

callWithNuxt returns a promise on server-side, so by not awaiting these instances we ran the risk of getting errors like:

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

In addition, callWithNuxt was previously returning any as its type rather than inferring it based on the input. This fixes that.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 January 23, 2023 09:44
@danielroe danielroe self-assigned this Jan 23, 2023
@codesandbox
Copy link

codesandbox bot commented Jan 23, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel vercel bot temporarily deployed to Preview January 23, 2023 09:47 Inactive
@danielroe danielroe merged commit c5d6db7 into main Jan 23, 2023
@danielroe danielroe deleted the fix/async-call branch January 23, 2023 11:13
@lukaszflorczak lukaszflorczak mentioned this pull request Jan 23, 2023
Closed
@danielroe danielroe mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels

bug 🔨 p3-minor types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe @pi0