…//codereview.chromium.org/312683005/)

Reason for revert:
This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905

BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
#1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
nwjs#2 0x7f2c232cd4a0 \u003Cunknown>
nwjs#3 0x7f2c2337f313 __poll
nwjs#4 0x7f2c240b6036 \u003Cunknown>
nwjs#5 0x7f2c240b6164 g_main_context_iteration
nwjs#6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
nwjs#7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
nwjs#8 0x7f2c2a2f69d8 base::RunLoop::Run()
nwjs#9 0x00000466bd59 content::RunThisRunLoop()
nwjs#10 0x00000466c1b8 content::MessageLoopRunner::Run()
nwjs#11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
nwjs#12 0x0000011fdf00 MediaBrowserTest::RunTest()
nwjs#13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
nwjs#14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
nwjs#15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
nwjs#16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
...

Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.

Original issue's description:
> IDL: Support optional argument default value syntax
> 
> Adds support for parsing default values of different types, but
> only handles null default values when generating code.
> 
> Replaces existing
> 
>   [Default=Null] optional SomeInterface arg
>   [Default=NullString] optional DOMString arg
> 
> with the now equivalent
> 
>   optional SomeInterface arg = null
>   optional DOMString arg = null
> 
> in IDL files, and drops support for those [Default] attributes.
> 
> No changes to generated code.
> 
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339683002

git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ax (https://codereview.chromium.org/339683002/)

Reason for revert:
Revert the revert because the bot went green even without this revert, and other bots had no trouble.

Original issue's description:
> Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/)
> 
> Reason for revert:
> This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905
> 
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
> #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
> nwjs#2 0x7f2c232cd4a0 \u003Cunknown>
> nwjs#3 0x7f2c2337f313 __poll
> nwjs#4 0x7f2c240b6036 \u003Cunknown>
> nwjs#5 0x7f2c240b6164 g_main_context_iteration
> nwjs#6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
> nwjs#7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
> nwjs#8 0x7f2c2a2f69d8 base::RunLoop::Run()
> nwjs#9 0x00000466bd59 content::RunThisRunLoop()
> nwjs#10 0x00000466c1b8 content::MessageLoopRunner::Run()
> nwjs#11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
> nwjs#12 0x0000011fdf00 MediaBrowserTest::RunTest()
> nwjs#13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
> nwjs#14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
> nwjs#15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
> nwjs#16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
> ...
> 
> Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.
> 
> Original issue's description:
> > IDL: Support optional argument default value syntax
> > 
> > Adds support for parsing default values of different types, but
> > only handles null default values when generating code.
> > 
> > Replaces existing
> > 
> >   [Default=Null] optional SomeInterface arg
> >   [Default=NullString] optional DOMString arg
> > 
> > with the now equivalent
> > 
> >   optional SomeInterface arg = null
> >   optional DOMString arg = null
> > 
> > in IDL files, and drops support for those [Default] attributes.
> > 
> > No changes to generated code.
> > 
> > BUG=258153
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200
> 
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339723002

git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

or debug callback can't get the listener.
Fix nwjs/nw.js#719

#0  WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800,
    scriptState=0x192e07eebb10, callFrames=..., exception=...)
    at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682
#1  0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram (
    this=0x7ffff7ee8260, executionState=..., exception=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425
nwjs#2  0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent (
    this=0x7ffff7ee8260, eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503
nwjs#3  0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback (
    eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435
nwjs#4  0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2953
nwjs#5  0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2932
nwjs#6  0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent (
    this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false)
    at ../../v8/src/debug.cc:2909
nwjs#7  0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak (
    this=0x7ffff7eec520, break_points_hit=..., auto_continue=false)
    at ../../v8/src/debug.cc:2750
nwjs#8  0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20,
    args=...) at ../../v8/src/debug.cc:992
nwjs#9  0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=...,
    isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062
nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0,
    args_object=0x7fffffff8248, isolate=0x7ffff7e80020)
    at ../../v8/src/debug.cc:1061

…id:100001 of https://codereview.chromium.org/810343003/)

Reason for revert:
Issue 452284:	10.1%-69.4% regression in blink_perf.svg at 312837:312949

Original issue's description:
> Fix pointer-events:all when stroke="none"
> 
> pointer-events:all should make event processing unaffected by the values
> of the 'stroke' and 'fill' properties. However, when the 'stroke' of a
> shape was set to "none", hit detection would fail for points that would
> be in the shape's stroke area if the 'stroke' were not "none".
> 
> Originally, two CLs were committed implementing a fix for the issue, but
> they were reverted due to a 200%-225% regression of a performance test:
> PerformanceTests/SVG/SvgHitTesting.html
> The performance regression was due to the change in strokeContains() that
> skipped the check whether the stroke bounding box contained the point if
> !requiresStroke.
> 
> The modified fix implemented by this commit has three parts:
> 1. m_innerStrokeRect/m_outerStrokeRect are deleted from RenderSVGRect.
>    This is because shapeDependentStrokeContains(), which was the only
>    user of these FloatRect objects, should ignore whether the shape
>    actually has a stroke, but m_innerStrokeRect and m_outerStrokeRect
>    were equal to the m_fillBoundingBox if the <rect> had no stroke.
> 2. The notion of the hit test stroke bounding box is introduced and a
>    new RenderSVGShape member is added: m_hitTestStrokeBoundingBox. The
>    hit test stroke bounding box of a shape is considered to be the
>    bounding box of the stroke, regardless of whether the shape has a
>    stroke. The stroke bounding box is usually m_hitTestStrokeBoundingBox
>    if the shape has a stroke; otherwise, it's m_fillBoundingBox. In the
>    case of RenderSVGPath, though, the stroke bounding box includes the
>    markerRect.
> 3. RenderSVGShape::strokeContains() was changed so that if !requiresStroke,
>    then we check whether the point is within the hit test stroke bounding
>    box. If requiresStroke, then we check whether the point is within the
>    stroke bounding box.
> 
> BUG=350338, 445410
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188888

[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=350338, 445410, 452284

Review URL: https://codereview.chromium.org/882443006

git-svn-id: svn://svn.chromium.org/blink/trunk@189035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/762603003/)

Reason for revert:
This breaks webkit_unit_tests in build bots: 

7 tests crashed:
    ViewDisplayListTest.CachedDisplayItems
    ViewDisplayListTest.ViewDisplayListTest_UpdateAddFirstOverlap
    ViewDisplayListTest.ViewDisplayListTest_UpdateBasic
    ViewDisplayListTest.ViewDisplayListTest_UpdateClip
    ViewDisplayListTest.ViewDisplayListTest_UpdateInvalidationWithPhases
    ViewDisplayListTest.ViewDisplayListTest_UpdateNewItemInMiddle
    ViewDisplayListTest.ViewDisplayListTest_UpdateSwapOrder

Example build: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15678

Original issue's description:
> Cache and reuse DrawingDisplayItems
> 
> - Combine m_paintListRenderers and m_invalidated hash sets in
>   DisplayItemList into m_cachedClients because we only need to know
>   which clients have display items validly cached.
> 
> - m_cachedClients is filled during updatePaintList(). Client is removed
>   when the client it's invalidated.
> 
> - Clear the whole DisplayItemList when a GraphicsLayer is fully
>   invalidated. This happens when the compositing state of layer changes
>   and all renderers in the layer should be invalidated, we invalidate
>   the GraphicsLayer directly instead of invalidating each renderer.
> 
> - Create CachedDisplayItem instead of DrawingDisplayItem during recording
>   if a renderer is validly cached.
> 
> TEST=ViewDisplayListTest.CachedDisplayItems
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186817

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/795463005

git-svn-id: svn://svn.chromium.org/blink/trunk@186859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…methods. (patchset #6 id:100001 of https://codereview.chromium.org/807003004/)

Reason for revert:
Breaks msvc: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20%28dbg%29/builds/4695

Original issue's description:
> Templatize visitor arguments for TraceTrait mark and trace methods.
> 
> This CL replaces Visitor* in TraceTrait<T>::{mark,trace} methods arguments
> to template parameter VisitorDispatcher.
> 
> This is to prepare for InlinedGlobalMarkingVisitor implementaion, so that
> those methods can also be used to dispatch
> TraceTrait<T>::mark(InlinedGlobalMarkingVisitor) in addition to the current
> TraceTrait<T>::mark(Visitor*) usage.
> 
> BUG=420515
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187674

[email protected],[email protected],[email protected],[email protected],[email protected]
BUG=420515

Review URL: https://codereview.chromium.org/828453003

git-svn-id: svn://svn.chromium.org/blink/trunk@187698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…Agent (patchset nwjs#6 id:100001 of https://codereview.chromium.org/1092123004/)

Reason for revert:
Reverting as a possible cause of issue 482468
BUG=482468

Original issue's description:
> DevTools: remove dependency of most agents on InspectorPageAgent
> 
> - let agents keep inspected frame directly rather than fetch it
>     from InspectorPageAgent::inspectedFrame();
> - get frames from InspectorIdentifiers<LocalFrame>, but check it
>     belongs to inspected page;
> 
> BUG=480341
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194592

[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=480341

Review URL: https://codereview.chromium.org/1118963002

git-svn-id: svn://svn.chromium.org/blink/trunk@194801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…dn't prevent selection (patchset nwjs#6 id:100001 of https://codereview.chromium.org/1013303003/)

Reason for revert:
Revert because there are applications (like Google maps - http://crbug.com/485892) which are relying on disabling text selection / drag and drop but are forced to avoid cancelling mousedown (due to http://crbug.com/269917).

Original issue's description:
> Preventing the default action on 'mousemove' listener shouldn't prevent selection
> 
> As per the spec, mousemove has no default action: 
> http://www.w3.org/TR/DOM-Level-3-Events/#event-type-mousemove.
> Hence preventing the default action on mousemove should not 
> prevent selection/drag from happening. Made changes to 
> allow drag operation irrespective of mousemove event 
> cancellation similar to behavior of other browsers.
> 
> BUG=346473
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192855

[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=346473

Review URL: https://codereview.chromium.org/1145433002

git-svn-id: svn://svn.chromium.org/blink/trunk@195334 bbb929c8-8fbe-4397-9dbb-9b2b20218538