Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 14, 2022

  • #824 Fixes large memory footprint of bedtools coverage calculation.
  • #822 Fixed post-adapterremoval trimmed files not being lane-merged and included in downstream analyse

Linting WILL fail because I had to pin the nf-core tools version, you can check for other errors manually if you want

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .). [DONE MANUALLY]
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested review from apeltzer and maxulysse January 14, 2022 14:44
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tiny change in comment required. Dunno where that came from.

@drpatelh
Copy link
Member

Need to fix the linting too.

Co-authored-by: Harshil Patel <[email protected]>
@jfy133
Copy link
Member Author

jfy133 commented Jan 17, 2022

Linting is just that I hardcoded the last DSL1 version of tools in the CI otherwise it always fails with a bunch of other DSL2 related issues

@jfy133 jfy133 requested a review from TCLamnidis January 24, 2022 15:31
Copy link
Collaborator

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfy133 jfy133 merged commit 37e860d into master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants