-
Notifications
You must be signed in to change notification settings - Fork 86
Release PR for 2.4.2 patch #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Version-bump
Bedtools process changes
Fix post-ar trimming not being included in downstream analyses
drpatelh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tiny change in comment required. Dunno where that came from.
|
Need to fix the linting too. |
Co-authored-by: Harshil Patel <[email protected]>
|
Linting is just that I hardcoded the last DSL1 version of tools in the CI otherwise it always fails with a bunch of other DSL2 related issues |
TCLamnidis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linting WILL fail because I had to pin the nf-core tools version, you can check for other errors manually if you want
PR checklist
scrape_software_versions.pynf-core lint .). [DONE MANUALLY]nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).