-
Notifications
You must be signed in to change notification settings - Fork 9
Dev #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #24
Conversation
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
add .fna support for pbmm2
Changing the names of the pbsv output
Co-authored-by: Felix Lenner <[email protected]>
fixing prefixing issue
update to version 1.0.1 for patch release
|
I have resolved these comments in #25 which should contain all the changes suggested, if you could take a look. Further I see there is a conflict with nextflow.config, but due to permissions im unable to look and resolved the conflict myself - how should I go about this? Thanks! |
|
@tanyasarkjain I've upgraded your repo permissions now (with great pwoer comes great responsbility!) Can you do it now? |
Co-authored-by: James A. Fellows Yates <[email protected]>
|
@jfy133 Hi James! I still seem to be seeing the "dev is a protected branch" unfortunately and unable to click the "resolve conflicts" |
requested changes for 1.0.1 release
|
@tanyasarkjain you need to do a manual merge, check the bottom of the box: |
|
The error in nextflow.config is coming from a merge conflict with the 1.0.1 update to the version. I tried using the command Lind instructions and could make the change locally, but can't seem to push my changes to dev: I get this message: Enumerating objects: 4, done. |
|
I think if you make a separate PR merged into dev with the same fix, the issue 'should' go away |
|
@jfy133 resolved :) |
Merge conflict resolution? (1.0.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one more question on the output naming because I now realized that you use multiple tools for variant calling for example :)
| ## v1.0.0 - Goldfish [01/31/2025] | ||
|
|
||
| Initial release of nf-core/pacvar, created with the [nf-core](https://nf-co.re/) template. | ||
| ## v1.0.1 - Sardine [02/26/2025] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## v1.0.1 - Sardine [02/26/2025] | |
| ## v1.0.1 - Sardine [2025-03-06] |
|
|
||
| ### `Deprecated` | ||
|
|
||
| ## v1.0.0 - Goldfish [01/31/2025] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## v1.0.0 - Goldfish [01/31/2025] | |
| ## v1.0.0 - Goldfish [2025-01-31] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).