Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tanyasarkjain
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pacvar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tanyasarkjain
Copy link
Collaborator Author

I have resolved these comments in #25 which should contain all the changes suggested, if you could take a look. Further I see there is a conflict with nextflow.config, but due to permissions im unable to look and resolved the conflict myself - how should I go about this? Thanks!

@jfy133
Copy link
Member

jfy133 commented Feb 28, 2025

@tanyasarkjain I've upgraded your repo permissions now (with great pwoer comes great responsbility!) Can you do it now?

Co-authored-by: James A. Fellows Yates <[email protected]>
@tanyasarkjain
Copy link
Collaborator Author

tanyasarkjain commented Feb 28, 2025

@jfy133 Hi James! I still seem to be seeing the "dev is a protected branch" unfortunately and unable to click the "resolve conflicts"

requested changes for 1.0.1 release
@jfy133
Copy link
Member

jfy133 commented Feb 28, 2025

@tanyasarkjain you need to do a manual merge, check the bottom of the box:

image

@tanyasarkjain
Copy link
Collaborator Author

tanyasarkjain commented Feb 28, 2025

@jfy133

The error in nextflow.config is coming from a merge conflict with the 1.0.1 update to the version. I tried using the command Lind instructions and could make the change locally, but can't seem to push my changes to dev: I get this message:

Enumerating objects: 4, done.
Counting objects: 100% (4/4), done.
Delta compression using up to 8 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (2/2), 279 bytes | 279.00 KiB/s, done.
Total 2 (delta 1), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (1/1), completed with 1 local object.
remote: error: GH013: Repository rule violations found for refs/heads/dev.
remote: Review all repository rules at https://github.com/nf-core/pacvar/rules?ref=refs%2Fheads%2Fdev
remote:
remote: - Changes must be made through a pull request.
remote:
remote: - 2 of 2 required status checks are expected.
remote:
To https://github.com/nf-core/pacvar.git
! [remote rejected] dev -> dev (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/nf-core/pacvar.git'

@jfy133
Copy link
Member

jfy133 commented Feb 28, 2025

I think if you make a separate PR merged into dev with the same fix, the issue 'should' go away

@tanyasarkjain
Copy link
Collaborator Author

tanyasarkjain commented Feb 28, 2025

@jfy133 resolved :)

Copy link

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one more question on the output naming because I now realized that you use multiple tools for variant calling for example :)

@tanyasarkjain tanyasarkjain requested a review from famosab March 4, 2025 19:30
## v1.0.0 - Goldfish [01/31/2025]

Initial release of nf-core/pacvar, created with the [nf-core](https://nf-co.re/) template.
## v1.0.1 - Sardine [02/26/2025]
Copy link
Member

@jfy133 jfy133 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## v1.0.1 - Sardine [02/26/2025]
## v1.0.1 - Sardine [2025-03-06]


### `Deprecated`

## v1.0.0 - Goldfish [01/31/2025]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## v1.0.0 - Goldfish [01/31/2025]
## v1.0.0 - Goldfish [2025-01-31]

Copy link

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tanyasarkjain tanyasarkjain merged commit 73596e1 into master Mar 6, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants