Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves warning messages in the nf-core subworkflow linting system by adding helpful context about when version-related warnings can be safely ignored. The changes clarify that warnings about missing software versions can be disregarded when subworkflows use topic channels, which handle version information differently.
Changes:
- Updated warning messages to indicate that version-related warnings can be ignored when using topic channels
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nf_core/subworkflows/lint/subworkflow_tests.py | Enhanced warning message for missing versions in snapshot files to clarify when the warning can be ignored |
| nf_core/subworkflows/lint/main_nf.py | Enhanced warning message for subworkflows that don't emit software versions to clarify when the warning can be ignored |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
22bd2fa to
d5785ae
Compare
mashehu
left a comment
There was a problem hiding this comment.
thanks, forgot that we also had that check in subworkflows.
|
Thank you ! |
These warnings can be ignored if the subworkflow is using topic channel.
PR checklist
CHANGELOG.mdis updateddocsis updated