Replace webhook notifications with nf-slack plugin#4051
Replace webhook notifications with nf-slack plugin#4051FriederikeHanssen wants to merge 3 commits intonf-core:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace the old webhook-based Slack/Teams notification system (hook_url, slackreport.json, adaptivecard.json, imNotification function) with the nf-slack plugin. The plugin is declared entirely within the CI workflow's nextflow_config block, keeping local runs completely unaffected. Co-Authored-By: Claude Opus 4.6 <[email protected]>
5f45b85 to
b0359d5
Compare
There was a problem hiding this comment.
this needs to be fixed upstream in the modules repo not here
There was a problem hiding this comment.
| custom_pipelines: True | ||
| default: true | ||
|
|
||
| slackreport: |
There was a problem hiding this comment.
i think we should keep this feature and it now just adds the plugin to the nextflow.config. with that no functionality gets lost.
There was a problem hiding this comment.
seems like the maintainers on slack are leaning towards removing this.
This change needs to happen upstream in nf-core/modules, not here. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
this code is not just for slack notficiations, it also includes MS teams notifications. I know that @nvnieuwk is working on it, but until we have that, I don't think we can remove this code completely, but just the slack part. |
Summary
hook_url,slackreport.json,adaptivecard.json,imNotification()) with the nf-slack pluginnextflow_configblock, keeping local runs completely unaffectedadaptivecardandslackreporttemplate featuresTest plan
nf-core pipelines createhook_url,slackreport,adaptivecard, orimNotification🤖 Generated with Claude Code