Template: Fix ANSI codes in header #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Finally!!! I was about to stick a permanent fixture to the left hand side of my screen 💯 |
drpatelh
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring all of the header code to use the
Ansilibrary like Nextflow does was too much hard work. I figured it was weird that we were only getting the partial code shown for the codes at the start of the strings though, so played around with that. Sure enough - if there is a character before the first code, then the existing code works fine.So, now, we have some bling undimmed hyphens are the start of the log. I added one at the end of the hyphen line too, to make it symmetrical:
Sparkly! ✨ And seems to fix #329.. ✅