Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Template: Fix ANSI codes in summary log messages#485

Merged
ewels merged 1 commit intonf-core:devfrom
ewels:ansi-fix
Jan 27, 2020
Merged

Template: Fix ANSI codes in summary log messages#485
ewels merged 1 commit intonf-core:devfrom
ewels:ansi-fix

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jan 27, 2020

Should hopefully fix #442

@ewels ewels added the template nf-core pipeline/component template label Jan 27, 2020
@ewels ewels requested review from a team and drpatelh January 27, 2020 09:45
@maxulysse
Copy link
Member

So if this is NF/groovy log specific, there is some hope that it'll be fixed at some point, and we can remove this hack?

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't say that it looks good, but it works

@ewels
Copy link
Member Author

ewels commented Jan 27, 2020

So if this is NF/groovy log specific, there is some hope that it'll be fixed at some point, and we can remove this hack?

Hopefully! Though I doubt that this is a high priority. I had a look in the nextflow code for this a while back but couldn't figure out a fix.

@drpatelh
Copy link
Member

Yes, I did try this when you introduced the fix in the logo @ewels and I chose to persist in finding something that looks consistent with the rest of the stuff thats printed to screen. Anyhow, this is better than what we have currently so maybe we leave the issue open until we find a better fix?

@ewels ewels merged commit dc73902 into nf-core:dev Jan 27, 2020
@ewels ewels deleted the ansi-fix branch January 27, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

template nf-core pipeline/component template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants