CI Tests: Force package version to be dev #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Dropped Python 2.7 from the Travis test config, due to installation errors. It's 2020 now, no-one is left using Py2k any more, right..? |
drpatelh
approved these changes
Jan 27, 2020
Member
drpatelh
left a comment
There was a problem hiding this comment.
Agreed! Bit hacky but it works for now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CI tests on the linting code fail when the package version is stable.
This is because the minimal working example hardcodes
devfor the Dockerfile version:tools/tests/lint_examples/minimalworkingexample/Dockerfile
Line 1 in 615c6a5
The template tags this Dockerfile version based on the active python version number:
tools/nf_core/pipeline-template/{{cookiecutter.name_noslash}}/Dockerfile
Line 1 in 615c6a5
The lint code checks for the same:
tools/nf_core/lint.py
Line 920 in 615c6a5
This fix is a little hacky, but basically just makes the package version number include
devif it doesn't, so that the CI tests run properly.One day we should probably refactor how these tests work to get around these kinds of problems.. But for now this should get things working again, in lieu of a fairly complete rewrite.