Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Dockstore config file to template #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewels merged 2 commits into from
Jul 29, 2020
Merged

Add Dockstore config file to template #690

ewels merged 2 commits into from
Jul 29, 2020

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jul 23, 2020 •
edited
Loading

Added a .github/.dockstore.yml config file for automatic registration with dockstore.org

Many thanks to @agduncan94 for working on this and suggesting this route for us.

Please wait to merge until we have confirmation that having the config file inside the .github directory will be supported by Dockstore.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@ewels ewels requested review from agduncan94 and apeltzer July 23, 2020 13:08
@ewels ewels mentioned this pull request Jul 25, 2020
Merged
8 tasks
@ewels
Copy link
Member Author

ewels commented Jul 29, 2020

@agduncan94 - are you happy for us to go ahead and merge this? I'd like to push out a release + template sync soon, so would be good to get this in before then if possible (doesn't need to be supported yet - just to know that it will be supported).

Thanks!

agduncan94
agduncan94 approved these changes Jul 29, 2020
View reviewed changes
Copy link

@agduncan94 agduncan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can confirm that we will be supporting this soon.

@ewels ewels marked this pull request as ready for review July 29, 2020 19:05
@ewels
Copy link
Member Author

ewels commented Jul 29, 2020

Brilliant stuff - thanks!

@ewels ewels merged commit 50587d7 into nf-core:dev Jul 29, 2020
@ewels ewels deleted the dockstore-config branch July 29, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeltzer apeltzer apeltzer approved these changes

@agduncan94 agduncan94 agduncan94 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ewels @apeltzer @agduncan94