Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use new Rich syntax for markup logs. #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewels merged 1 commit into from
Jul 27, 2020
Merged

Use new Rich syntax for markup logs. #692

ewels merged 1 commit into from
Jul 27, 2020

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jul 23, 2020

Use new argument for the Rich logging handler. Removed all of the extra={"markup":True} statements in various logging calls.

See Textualize/rich#171 - thanks for the super-fast feature addition @willmcgugan!

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@ewels ewels added the command line tools Anything to do with the cli interfaces label Jul 23, 2020
@ewels ewels requested a review from a team July 23, 2020 19:00
@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #692 into dev will not change coverage.
The diff coverage is 45.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #692   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files          13       13           
  Lines        2696     2696           
=======================================
  Hits         2195     2195           
  Misses        501      501
Impacted Files Coverage Δ
nf_core/__main__.py 64.86% <ø> (ø)
nf_core/bump_version.py 94.36% <ø> (ø)
nf_core/create.py 94.44% <ø> (ø)
nf_core/launch.py 70.02% <0.00%> (ø)
nf_core/sync.py 62.25% <0.00%> (ø)
nf_core/schema.py 87.67% <66.66%> (ø)
nf_core/lint.py 91.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b84b54...33cd975. Read the comment docs.

maxulysse
maxulysse approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ewels ewels merged commit 5218db5 into nf-core:dev Jul 27, 2020
@ewels ewels deleted the rich-cleaner-logging branch July 27, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

No one assigned

Labels

command line tools Anything to do with the cli interfaces

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewels @maxulysse