-
Notifications
You must be signed in to change notification settings - Fork 223
New new schema #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New new schema #698
Conversation
update json-schema template to new structure
* Check that we have at least 1 parameter, fail if not * Log number of parameters found
* Use 'pipeline schema' instead of 'JSON Schema' in logging * Work with top-level schema and defintions sub-schema * Strip out logic about object-type properties * Test nf-core schema build with dummy pipeline
Also update all pytest.mark.xfail to use strict=True, so fails if an exception is not raised.
Check for presence and values of top-level $schema, $id, title and description
New-new schema
|
Assuming tests pass again, will self-merge as this PR is a combination of other smaller PRs that have already been reviewed. |
Codecov Report
@@ Coverage Diff @@
## dev #698 +/- ##
==========================================
+ Coverage 81.41% 82.49% +1.07%
==========================================
Files 13 13
Lines 2696 2725 +29
==========================================
+ Hits 2195 2248 +53
+ Misses 501 477 -24
Continue to review full report at Codecov.
|
Now that tests are passing again and the cli tools match the updated template, I think that we can merge this to dev.