Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Schema build bug #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewels merged 5 commits into from
Jul 29, 2020
Merged

Schema build bug #699

ewels merged 5 commits into from
Jul 29, 2020

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jul 29, 2020

Fix issues with the schema build code that was doing weird stuff when making a new schema - bug found by @mashehu

Also revert the template JSON schema back to 4-space padding instead of 2, to limit the diffs when people edit their schema from the template.

ewels added 2 commits July 29, 2020 10:50
@ewels
Template schema back to 4-space padding again
f585505 
This is because the Python library dumps JSON with 4-space padding. So if the template has 2-space, if we make even the tiniest change the the diff replaces the whole schema with whitespace changes.
@ewels
Tidy up code for generating new schema from scratch
fc25c93
@ewels ewels requested a review from mashehu July 29, 2020 09:11
@ewels
Copy link
Member Author

ewels commented Jul 29, 2020

Diff without whitespace: https://github.com/nf-core/tools/pull/699/files?diff=unified&w=1

@codecov

This comment has been minimized.

Sign in to view
@mashehu
Copy link
Contributor

mashehu commented Jul 29, 2020 •
edited
Loading

I think we should favor the web builder, so the dialog should be a [Y/n].
I don't have enough familiarity with cli layouting (yet), but could we indent the launch dialog and have the space between "🚀" and "Launch" not ignored:
Screenshot 2020-07-29 at 11 23 05

@ewels
Copy link
Member Author

ewels commented Jul 29, 2020

I think we should favor the web builder, so the dialog should be a [Y/n].

It did have this previously, but when I switched to using rich for this I removed the defaults for all confirmation prompts. At the time I was thinking that it was better to have people actively think about it rather than just hitting enter, but maybe you're right and we should set it to true by default in this case.

have the space between "🚀" and "Launch" not ignored:

Odd, that has a space for me:

image

I'll double-space it and add some indentation.

@ewels
Copy link
Member Author

ewels commented Jul 29, 2020

image

@mashehu
Copy link
Contributor

mashehu commented Jul 29, 2020

Duplication bug seems to be fixed now. One more bug: the command line keeps waiting for form completion, even after I clicked finished in the browser.

@ewels ewels mentioned this pull request Jul 29, 2020
Merged
@ewels
Copy link
Member Author

ewels commented Jul 29, 2020

Good spot, fixed in nf-core/website#467

@ewels ewels reopened this Jul 29, 2020
@ewels
Copy link
Member Author

ewels commented Jul 29, 2020

Now that the website bug has been fixed and merged / deployed, this should work as advertised 👍🏻

@mashehu
Copy link
Contributor

mashehu commented Jul 29, 2020

Yes, works as advertised!

@ewels ewels merged commit 24aa954 into nf-core:dev Jul 29, 2020
@ewels ewels deleted the schema-build-bug branch July 29, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewels @mashehu