Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jul 29, 2020

Schema linting - split out the title + description checks:

  • Don't call as part of the main schema validation function
    • This means that nf-core launch and other tools that require a valid schema to work still launch even if you have a typo in your schema description
  • nf-core schema validate throws log warnings to the command line about this check
  • nf-core lint throws lint warnings about this check

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #701 into dev will decrease coverage by 0.08%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #701      +/-   ##
==========================================
- Coverage   82.13%   82.04%   -0.09%     
==========================================
  Files          13       13              
  Lines        2737     2746       +9     
==========================================
+ Hits         2248     2253       +5     
- Misses        489      493       +4     
Impacted Files Coverage Δ
nf_core/__main__.py 62.68% <0.00%> (-0.95%) ⬇️
nf_core/lint.py 91.69% <66.66%> (-0.24%) ⬇️
nf_core/schema.py 88.23% <90.00%> (+0.27%) ⬆️
nf_core/list.py 80.45% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24aa954...878f841. Read the comment docs.

@ewels ewels merged commit aac5185 into nf-core:dev Jul 29, 2020
@ewels ewels deleted the schema-lint-warn branch July 29, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants