Thanks to visit codestin.com
Credit goes to github.com

Skip to content

v1.10.1 patch release #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewels merged 11 commits into from
Jul 30, 2020
Merged

v1.10.1 patch release #707

ewels merged 11 commits into from
Jul 30, 2020

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jul 30, 2020

Patch release to fix the automatic template synchronisation, which failed in the v1.10 release.

  • Improved logging: nf-core --log-file log.txt now saves a verbose log to disk.
  • nf-core/tools GitHub Actions pipeline sync now uploads verbose log as an artifact.
  • Sync - fixed several minor bugs, made logging less verbose.
  • Python Rich library updated to >=4.2.1
  • Hopefully fix git config for pipeline sync so that commit comes from @nf-core-bot
  • Fix sync auto-PR text indentation so that it doesn't all show as code
  • Added explicit flag --show-passed for nf-core lint instead of taking logging verbosity

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from a team July 30, 2020 19:13
@ewels
Copy link
Member Author

ewels commented Jul 30, 2020

If you're curious, the actual bug fix for the thing that crashed the sync in the previous release is in cb3532a

I'll put the diff here for convenience:

-  "[green]Sync successful for {}:[/] [blue][link={1}]{1}[/link]".format(
+  "[green]Sync successful for {0}:[/] [blue][link={1}]{1}[/link]".format(

Of course, I won't know if I've actually fixed it or not until we do another release... 😰

@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #707 into dev will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #707      +/-   ##
==========================================
- Coverage   82.04%   81.98%   -0.07%     
==========================================
  Files          13       13              
  Lines        2746     2753       +7     
==========================================
+ Hits         2253     2257       +4     
- Misses        493      496       +3
Impacted Files Coverage Δ
nf_core/__main__.py 61.81% <42.85%> (-0.87%) ⬇️
nf_core/sync.py 62.56% <75.00%> (+0.30%) ⬆️
nf_core/lint.py 91.86% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11fc75e...d67d824. Read the comment docs.

@ewels ewels merged commit 441bab7 into nf-core:dev Jul 30, 2020
@ewels ewels deleted the sync-fixes branch July 30, 2020 19:35
@ewels ewels mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewels @drpatelh