Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix bug for updated messages #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewels merged 3 commits into from
Mar 22, 2021
Merged

fix bug for updated messages #930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a59f497
fix bug for updated messages
KevinMenden Mar 22, 2021
d1a9fb7
update pytests
KevinMenden Mar 22, 2021
153e5fa
black
KevinMenden Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions nf_core/modules/lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ def check_module_changes(self, nfcore_modules):
Downloads the 'main.nf', 'functions.nf' and 'meta.yml' files for every module
and compare them to the local copies
"""
all_modules_up_to_date = True
files_to_check = ["main.nf", "functions.nf", "meta.yml"]

progress_bar = rich.progress.Progress(
Expand Down Expand Up @@ -420,7 +419,6 @@ def check_module_changes(self, nfcore_modules):
remote_copy = r.content.decode("utf-8")

if local_copy != remote_copy:
all_modules_up_to_date = False
self.warned.append(
LintResult(
mod,
Expand All @@ -429,6 +427,15 @@ def check_module_changes(self, nfcore_modules):
f"{os.path.join(mod.module_dir, f)}",
)
)
else:
self.passed.append(
LintResult(
mod,
"check_local_copy",
"Local copy of module up to date",
f"{os.path.join(mod.module_dir, f)}",
)
)
except UnicodeDecodeError as e:
self.warned.append(
LintResult(
Expand All @@ -439,9 +446,6 @@ def check_module_changes(self, nfcore_modules):
)
)

if all_modules_up_to_date:
self.passed.append("All modules are up to date!")


class NFCoreModule(object):
"""
Expand Down
2 changes: 1 addition & 1 deletion tests/test_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def test_modules_lint_fastqc(self):
self.mods.install("fastqc")
module_lint = nf_core.modules.ModuleLint(dir=self.pipeline_dir)
module_lint.lint(print_results=False, all_modules=True)
assert len(module_lint.passed) == 16
assert len(module_lint.passed) == 18
assert len(module_lint.warned) == 0
assert len(module_lint.failed) == 0

Expand Down