remove containsKey() from validateParams() #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
closes #937 |
Codecov Report
@@ Coverage Diff @@
## dev #939 +/- ##
=======================================
Coverage 69.56% 69.56%
=======================================
Files 34 34
Lines 4173 4173
=======================================
Hits 2903 2903
Misses 1270 1270
Continue to review full report at Codecov.
|
ewels
approved these changes
Mar 22, 2021
| "params.container", | ||
| "params.singleEnd", | ||
| "params.igenomesIgnore", | ||
| "params.name", |
| } | ||
| } | ||
| if(rawSchema.keySet().contains('properties') && rawSchema.get('properties').containsKey(ignore_param)) { | ||
| if(rawSchema.keySet().contains('properties') && rawSchema.get('properties').keySet().contains(ignore_param)) { |
Member
There was a problem hiding this comment.
ah right, yeah if nothing else this looks more consistent too 👍🏻
I guess that we changed the initial call at some point but as we never tested on a pipeline that had ungrouped params we didn't see the failure / didn't update the second call..
Contributor
Author
There was a problem hiding this comment.
Yep, I had a feeling this could happen with exactly this part of the code :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use
.keySet().contains()instead of.containsKey(), the problems at https://github.com/nf-core/diaproteomics/pull/103/checks?check_run_id=2167429157 are fixed.